Updated VoiceOver text according to the feedback #5233
Conversation
|
@mazevedofs can you please review this. Thank you. |
|
Hi @anvithagowda098 ! Thanks for the PR - I'd love to invite you to look at accessibility traits - these allow you to add the traits like isButton so that it reads out to the user - instead of doing things like [button], this would be a better way. Thank you! |
…da098/wikipedia-ios into voiceover-text-update Adding accessibility traits
|
@l-olson1214 Hey, I have made the necessary changes. |
| public static let editorKeyboardButtonLinkAccessiblityLabel = WMFLocalizedString("editor-keyboard-link-accessibility", value: "Link", comment: "Accessibility label for link keyboard button on the editor.") | ||
|
|
||
| public static let editorToolbarButtonTemplateAccessiblityLabel = WMFLocalizedString("editor-toolbar-template-accessibility", value: "Template text formatting", comment: "Accessibility label for template toolbar button on the editor.") | ||
| public static let editorToolbarButtonTemplateAccessiblityLabel = WMFLocalizedString("editor-toolbar-template-accessibility", value: "Double tap to add a template to the current node.", comment: "Accessibility label for template toolbar button on the editor.") |
There was a problem hiding this comment.
The "current node" text doesn't make sense in this context, nor is double tapping needed for this button, so this text is an incorrect instruction.
Ideally, it should be something like "Add template"
| public static let editorKeyboardButtonTemplateAccessiblityLabel = WMFLocalizedString("editor-keyboard-template-accessibility", value: "Template", comment: "Accessibility label for template keyboard button on the editor.") | ||
|
|
||
| public static let editorToolbarButtonImageAccessiblityLabel = WMFLocalizedString("editor-toolbar-image-accessibility", value: "Image text formatting", comment: "Accessibility label for image toolbar button on the editor.") | ||
| public static let editorToolbarButtonImageAccessiblityLabel = WMFLocalizedString("editor-toolbar-image-accessibility", value: "Double tap to add an image to the current node.", comment: "Accessibility label for image toolbar button on the editor.") |
There was a problem hiding this comment.
Same as above
The "current node" text doesn't make sense in this context, nor is double-tapping needed for this button, so this text is an incorrect instruction.
Ideally, it should be something like "Add image"
| "editor-toolbar-link-accessibility" = "Link text formatting"; | ||
| "editor-toolbar-list-ordered-accessibility" = "Ordered list text formatting"; | ||
| "editor-toolbar-list-unordered-accessibility" = "Unordered list text formatting"; | ||
| "editor-toolbar-image-accessibility" = "Image [button]. Double tap to add an image to the current node."; |
There was a problem hiding this comment.
This file should update when you build the project and commit the changes in this file and the related binaries.
Please commit the build changes as well.
|
Hi @anvithagowda098! I reviewed your last changes, let me know if you need any help. |
Phabricator: https://phabricator.wikimedia.org/T358301
Notes
Refined accessibility labels and VoiceOver text for editor toolbar and buttons.
Ensured VoiceOver correctly describes formatting options, navigation buttons, and editor actions.