Code cleanup

* Remove unused Attributes * Configure maven-release-plugin to make the release easier
wildfly-extras · Dec 4, 2024 · 8bff047 · 8bff047
1 parent 942e43b
commit 8bff047
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 26 deletions.
diff --git a/galleon-feature-pack/pom.xml b/galleon-feature-pack/pom.xml
@@ -91,15 +91,6 @@
     </modules>
 
     <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-release-plugin</artifactId>
-                <configuration>
-                    <tagNameFormat>@{project.version}</tagNameFormat>
-                </configuration>
-            </plugin>
-        </plugins>
         <pluginManagement>
             <plugins>
                 <plugin>

diff --git a/pom.xml b/pom.xml
@@ -166,6 +166,15 @@
     <build>
         <pluginManagement>
             <plugins>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-release-plugin</artifactId>
+                    <configuration>
+                        <tagNameFormat>@{project.version}</tagNameFormat>
+                        <preparationGoals>clean install</preparationGoals>
+                        <autoVersionSubmodules>true</autoVersionSubmodules>
+                    </configuration>
+                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>wildfly-assembly-plugin</artifactId>

diff --git a/subsystem/src/main/java/org/wildfly/extension/vertx/VertxOptionsAttributes.java b/subsystem/src/main/java/org/wildfly/extension/vertx/VertxOptionsAttributes.java
@@ -19,23 +19,6 @@
  */
 public abstract class VertxOptionsAttributes implements VertxConstants {
 
-  public static final SimpleAttributeDefinition VERTX_OPTION_FILE_PATH = new SimpleAttributeDefinitionBuilder(VertxConstants.ATTR_PATH, ModelType.STRING)
-    .setRequired(true)
-    .setAllowExpression(true)
-    .build();
-
-  private static final List<AttributeDefinition> VERTX_OPTIONS_FILE_ATTRS = new ArrayList<>();
-  static {
-    VERTX_OPTIONS_FILE_ATTRS.add(VERTX_OPTION_FILE_PATH);
-  }
-
-  /**
-   * @return Attributes used in element like: /subsystem=vertx/vertx-options-file=vof
-   */
-  static List<AttributeDefinition> getVertxOptionsFileAttributes() {
-    return VERTX_OPTIONS_FILE_ATTRS;
-  }
-
   public static final SimpleAttributeDefinition ATTR_EVENTLOOP_POOL_SIZE = new SimpleAttributeDefinitionBuilder(VertxConstants.ATTR_EVENTLOOP_POOL_SIZE, ModelType.INT)
     .setRequired(false)
     .setAllowExpression(true)