-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2 #240
Conversation
Hi @VAIBHAVCES |
|
Sorry @PrarthonaPaul , mistakenly closed the MR. Reopned it I updated the descripion with JIRA. Commit ID already havet the corresponding JIRA. |
Thanks @VAIBHAVCES! Just to let you know, I updated the base branch for the PR to 4.x (instead of 1.x). For any other ELYWEB issues that you work on, please submit the PR against the 4.x branch. We are currently updating the ELYWEB issues to mention this so others know as well. Feel free to let us know if you have any questions about that. This PR looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @VAIBHAVCES!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VAIBHAVCES
LGTM!
Hi @VAIBHAVCES, just noticed that this was closed but we hadn't merged it yet. Would you be able to re-open this? |
@fjuma @PrarthonaPaul . I am very sorry actually my forked repository was not syncing 4.x branch so to sync it I deleted my old forked repo, but eventually with that it deleted this PR too. And now I am not able to reopen it. I have reopened new PR can you please help me in get reviews on this one : #242 Apology for inconvenience. |
No worries at all! |
[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2
https://issues.redhat.com/browse/ELYWEB-214