Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2 #240

Closed
wants to merge 1 commit into from
Closed

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2 #240

wants to merge 1 commit into from

Conversation

VAIBHAVCES
Copy link

@VAIBHAVCES VAIBHAVCES commented Oct 12, 2023

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2

https://issues.redhat.com/browse/ELYWEB-214

image

@PrarthonaPaul
Copy link
Contributor

Hi @VAIBHAVCES
Thank you for the PR!
Could you add the ELYWEB issue link in the description and update the commit message to match the JIRA issue description? Thanks

@VAIBHAVCES
Copy link
Author

Hi @VAIBHAVCES Thank you for the PR! Could you add the ELYWEB issue link in the description and update the commit message to match the JIRA issue description? Thanks

@VAIBHAVCES VAIBHAVCES closed this Oct 12, 2023
@VAIBHAVCES VAIBHAVCES reopened this Oct 12, 2023
@VAIBHAVCES
Copy link
Author

VAIBHAVCES commented Oct 12, 2023

Sorry @PrarthonaPaul , mistakenly closed the MR. Reopned it

I updated the descripion with JIRA. Commit ID already havet the corresponding JIRA.

@fjuma fjuma changed the base branch from 1.x to 4.x October 12, 2023 19:08
@fjuma
Copy link
Contributor

fjuma commented Oct 12, 2023

Thanks @VAIBHAVCES! Just to let you know, I updated the base branch for the PR to 4.x (instead of 1.x).

For any other ELYWEB issues that you work on, please submit the PR against the 4.x branch. We are currently updating the ELYWEB issues to mention this so others know as well.

Feel free to let us know if you have any questions about that.

This PR looks good!

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @VAIBHAVCES!

Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VAIBHAVCES
LGTM!

@VAIBHAVCES VAIBHAVCES closed this by deleting the head repository Oct 13, 2023
@fjuma
Copy link
Contributor

fjuma commented Oct 13, 2023

Hi @VAIBHAVCES, just noticed that this was closed but we hadn't merged it yet. Would you be able to re-open this?

@VAIBHAVCES
Copy link
Author

@fjuma @PrarthonaPaul . I am very sorry actually my forked repository was not syncing 4.x branch so to sync it I deleted my old forked repo, but eventually with that it deleted this PR too. And now I am not able to reopen it.

I have reopened new PR can you please help me in get reviews on this one : #242

Apology for inconvenience.

@fjuma
Copy link
Contributor

fjuma commented Oct 13, 2023

No worries at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants