[UPD] long 2 loops #86
Conversation
| yield data | ||
| data = yield self.read(2) | ||
| yield data | ||
| for x in (1, 2, 4, 2): |
There was a problem hiding this comment.
Generally I would approve of such a change, but this code is a throwaway test for debugging, it doesn't run in normal usage. The repetition is somewhat intentional, it makes makes it clear at a glance how many bytes are being read while debugging.
There was a problem hiding this comment.
Generally I would approve of such a change, but this code is a throwaway test for debugging, it doesn't run in normal usage. The repetition is somewhat intentional, it makes makes it clear at a glance how many bytes are being read while debugging.
Fair enough :)
| Opcode.RESERVED8, | ||
| Opcode.RESERVED9, | ||
| Opcode.RESERVED10, | ||
| Opcode.__dict__[x] for x in Opcode.__dict__.keys() if x.startswith('RESERVED') |
There was a problem hiding this comment.
The original is a bit verbose, I'll grant you. But I don't mind the repetition here. The duplication is in a single file, and a literal has the advantage that it doesn't execute any code at import time. It's also unlikely to change any time soon, as far as I know the websocket protocol has stabilised.
There was a problem hiding this comment.
The original is a bit verbose, I'll grant you. But I don't mind the repetition here. The duplication is in a single file, and a literal has the advantage that it doesn't execute any code at import time. It's also unlikely to change any time soon, as far as I know the websocket protocol has stabilised.
Yes, I noticed that the Websockets has not changed since 2011..
I enjoyed reading the code and just could not help but make the change :).. habit
What this PR solves
I was reading through this excellent codebase and just came across 2 situations that were slightly, possibly violating DRY principles.
- It makes it unnecessary in the future to update the
reserved_opcodesfunction if theRESERVEDOpcodes become something.- in TestParser.parser, you could add other items to read/yield easier.
How it is done
Looping instead of repeating code.
What to look out for
I do not have the full test setup on my system so I cannot confirm or deny all Passes / Failures :)
Review