Conversation
AuditAudit artifacts not found. SchemaNo drift detected ✅ CodexNo Codex outputs yet. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fee2dd4c81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wileland
added a commit
that referenced
this pull request
Feb 20, 2026
* phase0-spine-lockdown-2026-02-19: lock meaning-spine contracts, enforce unique offsets, harden emission (#617) * chore(codex): phase0 spine lockdown task spec * chore(codex): tighten phase0 spine lockdown spec for codex web * fix(server): lock meaning spine contracts and receipt validation * feat(server): canonicalize transcripts at ingest v1 (#618) * codex(task): phase1 ingest transcript canonicalization v1 * feat(server): canonicalize transcripts at ingest v1 * fix(codex): align latest.json locks/scope; fold transcript whitespace safely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v1receipt validation is strict and never silently falls through to weaker matching.ENTRY_ANALYZEDemissions and surface a machine-readable contract ledger only.Description
server/src/utils/meaningSpineContracts.jswithCONTRACT_REASONSandRECEIPT_VALIDATION_REASONS, and replaced ad-hoc strings in the touched code paths.server/src/utils/narrativePolicy.jsexposingisNarrativeEnabled()and removed the sanitizer-level caller override for the narrative toggle, so callers cannot bypass the shared policy.server/src/workers/reflection.worker.js: addedfindUniqueReceiptOffsets()andhasAmbiguousQuoteMatch()so inferred offsets returnnullwhen a quote occurs multiple times; ambiguous inferred receipts are tagged withoffsetInference: 'AMBIGUOUS_MATCH'in canonicalization.validateReceiptinserver/src/utils/truthValidator.jsto return explicit failure reasons (INVALID_RECEIPT_SHAPE,OFFSET_AMBIGUOUS,MISSING_REQUIRED_FIELDS, etc.) and to use the newRECEIPT_VALIDATION_REASONSconstants.reflection.worker.js:sanitizeBloomCardsWithContract()returns sanitized cards plus a contract ledger;emitEntryAnalyzed()now includes the contract at top-level and only sanitizedbloom_cardsinsidemeaning.structuredDataand no longer emitsmeaning.textormeaning.summary(prevents raw model text exposure).coerceCards()now uses a neutral'Reflection'headline).server/tests/receipt.v1.test.jsnow references the shared constants and includes tests forINVALID_RECEIPT_SHAPEand ambiguous-offset dropping;server/src/workers/__tests__/reflection.worker.test.tsadds a test ensuring raw model text is not present in the serializedENTRY_ANALYZEDpayload.Testing
node scripts/codex_preflight.mjs --ciand it passed in the Codex Web context.pnpm install --frozen-lockfile.pnpm -C server testand the server test suite passed (server tests completed successfully).pnpm lint:ciandpnpm test:ci; both completed successfully.server/tests/receipt.v1.test.js(receipt-shape + ambiguous-offset assertions) andserver/src/workers/__tests__/reflection.worker.test.ts(emission serialization regression). All automated tests triggered in this run passed.Codex Task