feat(server): canonicalize transcripts at ingest v1#618
Merged
Conversation
AuditAudit artifacts not found. SchemaNo drift detected ✅ CodexNo Codex outputs yet. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5c9c9a888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wileland
added a commit
that referenced
this pull request
Feb 20, 2026
* phase0-spine-lockdown-2026-02-19: lock meaning-spine contracts, enforce unique offsets, harden emission (#617) * chore(codex): phase0 spine lockdown task spec * chore(codex): tighten phase0 spine lockdown spec for codex web * fix(server): lock meaning spine contracts and receipt validation * feat(server): canonicalize transcripts at ingest v1 (#618) * codex(task): phase1 ingest transcript canonicalization v1 * feat(server): canonicalize transcripts at ingest v1 * fix(codex): align latest.json locks/scope; fold transcript whitespace safely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
transcriptHashso receipts and downstream workers remain stable.Description
server/models/Entry.js:canonicalizeTranscriptV1,sha256Hex,buildCanonicalTranscriptPayload, andTRANSCRIPT_CANONICALIZATION_VERSION_V1.Entrymodel schema withrawTranscript,canonicalTranscript,transcriptHash, andcanonicalizationVersionand updatesetTranscriptStateto populate these fields on transcript writes.server/routes/upload.js(placeholder entry creation), GraphQLaddEntry/updateEntry(server/graphql/resolvers/index.js), and scribe worker persistence (server/src/workers/scribe.worker.js) to consistently store the canonical payload and version.server/src/workers/reflection.worker.js) to prefer persistedcanonicalTranscriptwhencanonicalizationVersion === '1'and fall back tocanonicalizeTranscriptV1for legacy entries, and include canonical fields in recent-history queries.server/models/__tests__/Entry.test.js, and updated worker/route tests to mock or exercise the new named exports and behavior.Testing
node -e "JSON.parse(require('fs').readFileSync('codex/tasks/latest.json','utf8')); console.log('latest.json ok')"which printedlatest.json ok(success).node scripts/codex_preflight.mjs --ciwhich passed (Codex Web context; preflight warnings about missing remote were expected and non-blocking).pnpm -C server testand observed the test suite complete with the updated test surface (final run: 219 tests passed, 5 skipped), indicating the canonicalization behavior and worker integration are covered and green.pnpm -C server lint:ciwhich failed in this environment due to an ESLint/AJV runtime incompatibility (TypeError: Cannot set properties of undefined (setting 'defaultMeta')) that is unrelated to these code changes; lint failure is environmental and not caused by the canonicalization edits.Codex Task