Conversation
AuditAudit artifacts not found. SchemaNo drift detected ✅ CodexNo Codex outputs yet. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11241e8427
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const emitEntryAnalyzed = (payload) => { | ||
| bus.emit(ENTRY_ANALYZED_EVENT, payload); | ||
| const envelope = toEntryAnalyzedEnvelope(payload); | ||
| validateEntryAnalyzedEnvelope(envelope); |
There was a problem hiding this comment.
Keep ENTRY_ANALYZED emitter backward-compatible
emitEntryAnalyzed now always validates the envelope, and with the new defaults a payload that omits processingStatus is treated as complete and must include non-empty bloomCards. Existing callers in this repo (for example scripts/simulate_nervous_system.js) still emit minimal payloads like { entryId, userId, cardsCreatedCount, analyzedAt }, so they now throw ENTRY_ANALYZED complete status requires cards before any listener executes, breaking that experiment workflow. Please either migrate those emitters in the same change or add a compatibility path when bloomCards is absent.
Useful? React with 👍 / 👎.
Sync main with develop after merging Run B failure-path firewall.