fix: golang inspection errors

will7200 · Jul 20, 2020 · 927740f · 927740f
1 parent 06eefc9
commit 927740f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 14 deletions.
diff --git a/cmd/crypto-sync/sync.go b/cmd/crypto-sync/sync.go
@@ -46,9 +46,6 @@ func (s *SyncCmd) Run(ctx *Context) error {
 		if holding == "coinbase" {
 			pricingData = holdingsProvider.(holdings.Price)
 		}
-		if err != nil {
-			return err
-		}
 		uHolding, err := account.GetHoldings()
 		if err != nil {
 			return err

diff --git a/pkg/personalcapital/accounts.go b/pkg/personalcapital/accounts.go
@@ -167,7 +167,7 @@ func (a *Accounts) GetAccounts(ctx context.Context, request *GetAccountsRequest)
 		return nil, err
 	}
 	if resp.StatusCode != 200 {
-		return nil, errors.New("Non 200 response")
+		return nil, errors.New("non 200 response")
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {

diff --git a/pkg/personalcapital/client.go b/pkg/personalcapital/client.go
@@ -239,7 +239,7 @@ func SaveSession(inClient *http.Client, baseURL string, fileName string) {
 }
 
 // LoadSession loads the cookies from a previously saved session file.
-func LoadSession(cookies *[]*(http.Cookie), fileName string) {
+func LoadSession(cookies *[]*http.Cookie, fileName string) {
 	cookiesFile, err := ioutil.ReadFile(fileName)
 	if err != nil {
 		log.Println(err)

diff --git a/pkg/personalcapital/holdings.go b/pkg/personalcapital/holdings.go
@@ -121,7 +121,7 @@ func (h *Holdings) GetHoldings(ctx context.Context, params *GetHoldingsParams) (
 		return nil, err
 	}
 	if resp.StatusCode != 200 {
-		return nil, errors.New("Non 200 response")
+		return nil, errors.New("non 200 response")
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
@@ -132,15 +132,15 @@ func (h *Holdings) GetHoldings(ctx context.Context, params *GetHoldingsParams) (
 	if err != nil {
 		return nil, err
 	}
-	holdings := new(GetHoldingsResponse)
-	holdings.SpData = ghr.SpData
+	lHoldings := new(GetHoldingsResponse)
+	lHoldings.SpData = ghr.SpData
 	if params.FilterUserCreated {
-		holdings.Holdings = FilterHoldsFromUser(holdings.Holdings)
+		lHoldings.Holdings = FilterHoldsFromUser(lHoldings.Holdings)
 	}
 	if params.FilterAccountName != "" {
-		holdings.Holdings = FilterHoldsByAccountName(holdings.Holdings, params.FilterAccountName)
+		lHoldings.Holdings = FilterHoldsByAccountName(lHoldings.Holdings, params.FilterAccountName)
 	}
-	return holdings, nil
+	return lHoldings, nil
 }
 
 func PCHoldingsToIHoldings(h []HoldingsType) []holdings.IHolding {
@@ -261,7 +261,7 @@ func (h *Holdings) UpdateHoldings(ctx context.Context, holding HoldingsUpdateReq
 		return nil, err
 	}
 	if resp.StatusCode != 200 {
-		return nil, errors.New("Non 200 response")
+		return nil, errors.New("non 200 response")
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
@@ -357,7 +357,7 @@ func (h *Holdings) AddHolding(ctx context.Context, holding *HoldingAddRequest) (
 		return nil, err
 	}
 	if resp.StatusCode != 200 {
-		return nil, errors.New("Non 200 response")
+		return nil, errors.New("non 200 response")
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {

diff --git a/pkg/personalcapital/login.go b/pkg/personalcapital/login.go
@@ -103,7 +103,7 @@ func (a *Authentication) AuthenticateWithPassword(ctx context.Context, params Au
 	}
 
 	if resp.StatusCode != 200 {
-		return errors.New("Non 200 response")
+		return errors.New("non 200 response")
 	}
 
 	body, err := ioutil.ReadAll(resp.Body)