refactor: remove calls to fatal in personal capital client

will7200 · May 31, 2021 · fce0562 · fce0562
1 parent 56e7832
commit fce0562
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/pkg/personalcapital/accounts.go b/pkg/personalcapital/accounts.go
@@ -139,7 +139,6 @@ func (a *Accounts) GetAccounts(ctx context.Context, request *GetAccountsRequest)
 	baseURL := a.client.cfg.Host
 	client := a.client.cfg.HTTPClient
 	csrf := *a.client.CSRF
-	log := a.client.cfg.Logger
 
 	var urlBuffer bytes.Buffer
 	urlBuffer.WriteString(baseURL)
@@ -171,7 +170,6 @@ func (a *Accounts) GetAccounts(ctx context.Context, request *GetAccountsRequest)
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
-		log.Sugar().Fatal(err)
 		return nil, err
 	}
 	update := GetAccountsResponse{}

diff --git a/pkg/personalcapital/holdings.go b/pkg/personalcapital/holdings.go
@@ -125,7 +125,7 @@ func (h *Holdings) GetHoldings(ctx context.Context, params *GetHoldingsParams) (
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
-		h.client.cfg.Logger.Sugar().Fatal(err)
+		return nil, err
 	}
 	ghr := GetHoldingsResponseExpecting{}
 	err = json.Unmarshal(body, &ghr)
@@ -265,7 +265,6 @@ func (h *Holdings) UpdateHoldings(ctx context.Context, holding HoldingsUpdateReq
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
-		h.client.cfg.Logger.Sugar().Fatal(err)
 		return nil, err
 	}
 	update := UpdateHoldingsResponse{}
@@ -372,7 +371,6 @@ func (h *Holdings) AddHolding(ctx context.Context, holding *HoldingAddRequest) (
 	}
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
-		h.client.cfg.Logger.Sugar().Fatal(err)
 		return nil, err
 	}
 	update := AddHoldingResponse{}