refactor: rm unnecessary passing of txtdb to trackers

[williamsjokvist]

Summary by CodeRabbit

• New Features

  • Streamlined game tracking for both T8 and SF6 by removing text-based storage dependencies.

• Bug Fixes

  • Enhanced logging for tracking processes to improve traceability during polling.

• Chores

  • Simplified constructor methods for T8 and SF6 trackers by removing unnecessary parameters.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the TrackingHandler, SF6Tracker, and T8Tracker structures and their methods. The primary updates include the removal of the txtDb parameter from the constructors and structures of both SF6Tracker and T8Tracker, indicating a shift to SQL-based storage. The SelectGame method in TrackingHandler has been updated accordingly. Additionally, logging enhancements have been made to the StartTracking method, improving traceability during the tracking process.

Changes

File Path	Change Summary
cmd/tracking.go	- Updated SelectGame method to remove txtDb from t8.NewT8Tracker and sf6.NewSF6Tracker constructors.
	- Added logging statement in StartTracking method for polling events.
pkg/tracker/sf6/track.go	- Removed txtDb field from SF6Tracker struct.
	- Updated NewSF6Tracker constructor to remove txtDb parameter.
pkg/tracker/t8/track.go	- Removed txtDb field from T8Tracker struct.
	- Updated NewT8Tracker constructor to remove txtDb parameter.

Possibly related PRs

• feat: tekken 8 support #165: Introduces support for Tekken 8, related to modifications in the TrackingHandler for handling game types.
• feat: force polling for t8 #184: Adds a ForcePoll method to the CommandHandler, enhancing polling functionality relevant to the main PR.
• refactor: unify polling mechanism #187: Unifies the polling mechanism, relating to changes in polling within the TrackingHandler.
• chore: use channels for browser src updates #190: Enhances TrackingHandler to support multiple match notification channels, aligning with updates in the main PR.
• refactor: rm biota #194: Modifications to SF6Tracker, particularly in the Poll method, reflecting changes in match tracking logic.

Suggested reviewers

• tifye

🐇 In the code, we hop and play,
No more txtDb in our way.
Trackers now sleek, with SQL in sight,
Polling enhanced, everything feels right!
With logs to guide us, we’ll never stray,
Hooray for the changes, hip-hip-hooray! 🥳

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.