Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tests for game selection #198

Merged
merged 2 commits into from
Oct 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions cmd/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ package cmd_test

import (
"fmt"
"log"
"os"
"testing"

"github.com/williamsjokvist/cfn-tracker/cmd"
"github.com/williamsjokvist/cfn-tracker/pkg/config"
"github.com/williamsjokvist/cfn-tracker/pkg/storage/nosql"
"github.com/williamsjokvist/cfn-tracker/pkg/storage/sql"
"github.com/williamsjokvist/cfn-tracker/pkg/storage/txt"
Expand All @@ -14,22 +17,31 @@ var testSuite = struct {
trackingHandler *cmd.TrackingHandler
}{}

func TestMain(t *testing.T) {
sqlDb, err := sql.NewStorage()
func TestMain(m *testing.M) {
sqlDb, err := sql.NewStorage(true)
if err != nil {
t.Fatal("failed to init sql store")
log.Fatalf("failed to init sql store: %v", err)
}
nosqlDb, err := nosql.NewStorage()
if err != nil {
t.Fatal("failed to init nosql store")
log.Fatalf("failed to init nosql store: %v", err)
}
txtDb, err := txt.NewStorage()
if err != nil {
t.Fatal("failed to init txt store")
log.Fatalf("failed to init txt store: %v", err)
}

testSuite.trackingHandler = cmd.NewTrackingHandler(nil, sqlDb, nosqlDb, txtDb, nil, nil)
cfg := config.Config{
AppVersion: "4.0.0",
Headless: true,
CapIDEmail: "test",
CapIDPassword: "test",
BrowserSourcePort: 4242,
}

testSuite.trackingHandler = cmd.NewTrackingHandler(nil, sqlDb, nosqlDb, txtDb, &cfg, nil)
testSuite.trackingHandler.SetEventEmitter(func(eventName string, optionalData ...interface{}) {
t.Log(fmt.Sprintf("[EVENT] %s", eventName), optionalData[0])
log.Println(fmt.Sprintf("[EVENT] %s", eventName), optionalData[0])
})
os.Exit(m.Run())
}
34 changes: 28 additions & 6 deletions cmd/tracking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,35 @@ import (

func TestTrackingSelectGame(t *testing.T) {
tests := []struct {
name string
gameType model.GameType
setup func(gameType model.GameType)
expErr error
}{}
name string
gameType model.GameType
expErrMsg string
}{
{
name: "select tekken 8",
gameType: model.GameTypeT8,
},
{
name: "select SF6",
gameType: model.GameTypeSF6,
expErrMsg: "browser not initialized",
},
{
name: "select game that doesn't exist",
gameType: "undefined",
expErrMsg: "failed to select game",
},
williamsjokvist marked this conversation as resolved.
Show resolved Hide resolved
}

for _, tt := range tests {
tt.setup(tt.gameType)
t.Run(tt.name, func(t *testing.T) {
err := testSuite.trackingHandler.SelectGame(tt.gameType)
if err == nil && tt.expErrMsg != "" {
t.Errorf("expected error: %q, got: nil", tt.expErrMsg)
}
if err != nil && err.Error() != tt.expErrMsg {
t.Errorf("unexpected error: got: %q, want: %q", err, tt.expErrMsg)
}
})
}
}
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func main() {
closeWithError(fmt.Errorf(`failed to launch browser: %v`, err))
return
}
sqlDb, err := sql.NewStorage()
sqlDb, err := sql.NewStorage(false)
if err != nil {
closeWithError(fmt.Errorf(`failed to initalize database: %w`, err))
return
Expand Down
9 changes: 7 additions & 2 deletions pkg/storage/sql/storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,16 @@ type Storage struct {
db *sqlx.DB
}

func NewStorage() (*Storage, error) {
func NewStorage(useInMemoryDb bool) (*Storage, error) {
if err := migrateSchema(nil); err != nil {
return nil, fmt.Errorf("failed to perform migrations: %w", err)
}
db, err := sqlx.Open("sqlite", getDataSource())
dataSource := getDataSource()
if useInMemoryDb {
dataSource = ":memory:"
}

db, err := sqlx.Open("sqlite", dataSource)
if err != nil {
return nil, fmt.Errorf("open sqlite connection: %w", err)
}
Expand Down
6 changes: 6 additions & 0 deletions pkg/tracker/sf6/cfn/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ func (c *Client) GetBattleLog(cfn string) (*BattleLog, error) {

func (t *Client) Authenticate(email string, password string, statChan chan tracker.AuthStatus) {
status := &tracker.AuthStatus{Progress: 0, Err: nil}

if t.browser == nil {
statChan <- *status.WithError(fmt.Errorf("browser not initialized"))
return
}

defer func() {
if r := recover(); r != nil {
log.Println(`Recovered from panic: `, r)
Expand Down