fix: fresh session first poll #236
Conversation
|
Warning Rate limit exceeded@williamsjokvist has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis pull request updates control flow and error handling in key tracking components. In the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant TH as TrackingHandler
participant DB as SQLDB
participant GT as GameTracker
participant EV as EventEmitter
C->>TH: StartTracking(userCode, restore=false)
TH->>DB: CreateSession(userCode)
DB-->>TH: Session created
TH->>GT: GetUser(userCode)
GT-->>TH: User details (LP, MR, DisplayName)
TH->>DB: Update session with user info
TH->>EV: Emit "match" event
TH-->>C: Return session
sequenceDiagram
participant T as SF6Tracker
participant BL as BattleLog Service
participant C as Cancel Handler
T->>BL: GetBattleLog()
alt Battle log is nil or error occurs
T->>C: Invoke cancel function
else Valid battle log
T->>T: Process match & update stats
end
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
cmd/tracking.go(1 hunks)pkg/model/config.go(1 hunks)pkg/tracker/sf6/track.go(1 hunks)
🧰 Additional context used
🪛 GitHub Check: go-lint
pkg/tracker/sf6/track.go
[failure] 40-40:
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
🪛 GitHub Actions: Lint go code
pkg/tracker/sf6/track.go
[error] 43-43: SA5011: possible nil pointer dereference (staticcheck)
🔇 Additional comments (5)
pkg/model/config.go (1)
9-9: Verify if this change belongs in this PR.The change to the default theme from "default" to "tekken" seems unrelated to fixing the first poll in a fresh session. Consider moving this change to a separate PR to maintain focused changes.
cmd/tracking.go (4)
78-82: LGTM! Improved session creation flow.Creating the session first, then fetching user details is a cleaner approach.
88-98: LGTM! Proper error handling and user details assignment.The code properly handles errors when fetching and saving user details, and correctly assigns the user's LP, MR, and DisplayName to the session.
99-105: LGTM! Added initial match state emission.Emitting the initial match state helps update the UI immediately with the user's current stats.
78-106: Verify potential race condition in session initialization.There's a potential race condition where the Poll method could be called before the session fields (LP, MR, UserName) are populated, as the ticker and polling goroutine are started immediately after session creation.
Consider moving the ticker and polling initialization after the session fields are populated:
session.UserName = user.DisplayName ch.eventEmitter("match", model.Match{ UserName: session.UserName, LP: session.LP, MR: session.MR, SessionId: session.Id, UserId: session.UserId, }) +// Initialize polling after session is fully populated ticker := time.NewTicker(30 * time.Second) ch.forcePollChan = make(chan struct{})
Summary by CodeRabbit