Use vertex index offset instead of 32bit indices

williamyang98 · Jul 24, 2023 · 70c0bb5 · 70c0bb5
1 parent addf6a7
commit 70c0bb5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 146 deletions.
diff --git a/cmake/Findimgui.cmake b/cmake/Findimgui.cmake
@@ -3,10 +3,6 @@ project(imgui)
 
 set(SRC_DIR ${CMAKE_CURRENT_LIST_DIR}/../vendor/imgui)
 
-# imconfig.h is required to use 32bit vertex indices
-# this is required since implot uses alot of vertices
-configure_file(cmake/imgui_imconfig.h.in ${SRC_DIR}/imconfig.h)
-
 add_library(imgui STATIC
     "${SRC_DIR}/imgui.h"
     "${SRC_DIR}/imgui_internal.h"
@@ -41,10 +37,10 @@ find_package(OpenGL REQUIRED)
 
 # set(IMGUI_DXLIBS glfw Vulkan::Vulkan)
 
-if (WIN32)
-set(IMGUI_DXLIBS glfw opengl32.lib)
+if(WIN32)
+    set(IMGUI_DXLIBS glfw opengl32.lib)
 else()
-set(IMGUI_DXLIBS glfw GL dl)
+    set(IMGUI_DXLIBS glfw GL dl)
 endif()
 
 # set(IMGUI_DXLIBS "d3d9.lib" "dxgi.lib" "d3dcompiler.lib")
@@ -55,16 +51,3 @@ target_include_directories(imgui PUBLIC "${SRC_DIR}")
 target_include_directories(imgui PUBLIC "${SRC_DIR}/backends")
 target_include_directories(imgui PUBLIC "${SRC_DIR}/misc/cpp")
 target_link_libraries(imgui PUBLIC ${IMGUI_DXLIBS})
-
-# Disable multiprocessing since this break debug builds for msbuild
-# target_compile_definitions(imgui PUBLIC "/MP")
-
-# add_executable(imgui_example "examples/example_win32_directx9/main.cpp")
-# add_executable(imgui_example "examples/example_win32_directx11/main.cpp")
-# add_executable(imgui_example "examples/example_win32_directx12/main.cpp")
-# add_executable(imgui_example "examples/example_glfw_vulkan/main.cpp")
-# add_executable(imgui_example "examples/example_glfw_opengl3/main.cpp")
-# target_include_directories(imgui_example PRIVATE "backends/")
-# target_link_libraries(imgui_example PRIVATE imgui)
-# target_link_libraries(imgui_example PRIVATE ${IMGUI_DXLIBS})
-# target_compile_definitions(imgui_example PUBLIC "/MP")
diff --git a/cmake/imgui_imconfig.h.in b/cmake/imgui_imconfig.h.in
diff --git a/examples/gui/imgui_skeleton.cpp b/examples/gui/imgui_skeleton.cpp
@@ -48,8 +48,11 @@ void ImguiSkeleton::AfterGLFWInit() {
 }
 
 void ImguiSkeleton::AfterImguiContextInit() {
-
     ImGuiIO& io = ImGui::GetIO();
+
+    // implot produces large meshes so we need to use vertex index offsets
+    io.BackendFlags |= ImGuiBackendFlags_RendererHasVtxOffset;
+
     io.ConfigFlags |= ImGuiConfigFlags_NavEnableKeyboard;       // Enable Keyboard Controls
     //io.ConfigFlags |= ImGuiConfigFlags_NavEnableGamepad;      // Enable Gamepad Controls
     io.ConfigFlags |= ImGuiConfigFlags_DockingEnable;           // Enable Docking