override-Annotation ergänzt und Verweiskommentar entfernt in `../pass…

…ports/` (Teil von #82)
willuhn · Feb 16, 2022 · 4f50a15 · 4f50a15
1 parent b95cb64
commit 4f50a15
Show file tree

Hide file tree

Showing 56 changed files with 279 additions and 721 deletions.
diff --git a/src/de/willuhn/jameica/hbci/passport/PassportHandle.java b/src/de/willuhn/jameica/hbci/passport/PassportHandle.java
@@ -101,7 +101,6 @@ public interface PassportHandle extends Remote
    * @param msg
    * @param datatype
    * @param retData
-   * @see org.kapott.hbci.callback.HBCICallback#callback(org.kapott.hbci.passport.HBCIPassport, int, java.lang.String, int, java.lang.StringBuffer)
    * @return true, wenn der Handler den Callback behandeln konnte.
    * @throws Exception
    */

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/Controller.java b/src/de/willuhn/jameica/hbci/passports/ddv/Controller.java
@@ -115,6 +115,7 @@ public TablePart getConfigList() throws RemoteException
 
     this.configList = new TablePart(DDVConfigFactory.getConfigs(),new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         GUI.startView(Detail.class,context);
@@ -127,6 +128,7 @@ public void handleAction(Object context) throws ApplicationException
     ContextMenu ctx = new ContextMenu();
 
     ctx.addItem(new CheckedContextMenuItem(i18n.tr("Öffnen"),new Action() {
+      @Override
       public void handleAction(Object context) throws ApplicationException {
         if (context == null)
           return;
@@ -142,11 +144,13 @@ public void handleAction(Object context) throws ApplicationException {
     },"document-open.png"));
 
     ctx.addItem(new ContextMenuItem(i18n.tr("Neue Konfiguration..."),new Action() {
+      @Override
       public void handleAction(Object context) throws ApplicationException {handleCreate();}
     },"document-new.png"));
 
     ctx.addItem(ContextMenuItem.SEPARATOR);
     ctx.addItem(new CheckedContextMenuItem(i18n.tr("Löschen..."),new Action() {
+      @Override
       public void handleAction(Object context) throws ApplicationException {handleDelete((DDVConfig)context);}
     },"user-trash-full.png"));
 
@@ -371,9 +375,7 @@ public void handleScan()
     {
       private boolean stop = false;
 
-      /**
-       * @see de.willuhn.jameica.system.BackgroundTask#run(de.willuhn.util.ProgressMonitor)
-       */
+      @Override
       public void run(final ProgressMonitor monitor) throws ApplicationException
       {
         final DDVConfig config = DDVConfigFactory.scan(monitor,this);
@@ -419,17 +421,13 @@ public void run()
         }
       }
 
-      /**
-       * @see de.willuhn.jameica.system.BackgroundTask#interrupt()
-       */
+      @Override
       public void interrupt()
       {
         this.stop = true;
       }
 
-      /**
-       * @see de.willuhn.jameica.system.BackgroundTask#isInterrupted()
-       */
+      @Override
       public boolean isInterrupted()
       {
         return this.stop;
@@ -633,6 +631,7 @@ public void handleChangeBankData()
       return;
 
     Application.getController().start(new BackgroundTask() {
+      @Override
       public void run(ProgressMonitor monitor) throws ApplicationException
       {
         HBCIPassportChipcard passport = null;
@@ -706,7 +705,9 @@ public void run(ProgressMonitor monitor) throws ApplicationException
         }
       }
 
+      @Override
       public boolean isInterrupted(){return false;}
+      @Override
       public void interrupt(){}
     });
   }
@@ -716,9 +717,7 @@ public void interrupt(){}
    */
   private class PresetListener implements Listener
   {
-    /**
-     * @see org.eclipse.swt.widgets.Listener#handleEvent(org.eclipse.swt.widgets.Event)
-     */
+    @Override
     public void handleEvent(Event event)
     {
       try {

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/DDVConfig.java b/src/de/willuhn/jameica/hbci/passports/ddv/DDVConfig.java
@@ -56,17 +56,13 @@ public String getId()
     return this.id;
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passport.Configuration#getDescription()
-   */
+  @Override
   public String getDescription()
   {
     return this.getReaderPreset().getName() + " (" + this.getName() + ")";
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passport.Configuration#getConfigDialog()
-   */
+  @Override
   public Class getConfigDialog() throws RemoteException
   {
     return Detail.class;
@@ -367,9 +363,7 @@ void deleteProperties()
     settings.setAttribute(this.getPrefix() + "konto",(String[]) null);
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passport.Configuration#delete()
-   */
+  @Override
   public void delete() throws ApplicationException
   {
     DDVConfigFactory.delete(this);

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/Detail.java b/src/de/willuhn/jameica/hbci/passports/ddv/Detail.java
@@ -28,9 +28,7 @@ public class Detail extends AbstractView
 {
   private final static I18N i18n = Application.getPluginLoader().getPlugin(HBCI.class).getResources().getI18N();
 
-  /**
-   * @see de.willuhn.jameica.gui.AbstractView#bind()
-   */
+  @Override
   public void bind() throws Exception
   {
     GUI.getView().setTitle(i18n.tr("Details der Kartenleser-Konfiguration"));
@@ -76,34 +74,39 @@ public void bind() throws Exception
     ButtonArea buttonArea = new ButtonArea();
     buttonArea.addButton(i18n.tr("BPD/UPD"),new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleDisplayProperties();
       }
     },null,false,"document-properties.png");
     buttonArea.addButton(i18n.tr("Synchronisieren"),new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleSync();
       }
     },null,false,"view-refresh.png");
     buttonArea.addButton(i18n.tr("Konfiguration testen"), new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleTest();
       }
     },null,false,"dialog-information.png");
     buttonArea.addButton(i18n.tr("Bankdaten ändern"), new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleChangeBankData();
       }
     },null,false,"system-users.png");
     buttonArea.addButton(i18n.tr("Speichern"),new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
       	control.handleStore();
@@ -113,9 +116,7 @@ public void handleAction(Object context) throws ApplicationException
     buttonArea.paint(getParent());
   }
 
-  /**
-   * @see de.willuhn.jameica.gui.AbstractView#canBookmark()
-   */
+  @Override
   public boolean canBookmark()
   {
     return false;

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/KontoList.java b/src/de/willuhn/jameica/hbci/passports/ddv/KontoList.java
@@ -48,9 +48,7 @@ public KontoList(DDVConfig config) throws RemoteException
     this.myConfig = config;
   }
 
-  /**
-   * @see de.willuhn.jameica.gui.parts.TablePart#paint(org.eclipse.swt.widgets.Composite)
-   */
+  @Override
   public synchronized void paint(Composite parent) throws RemoteException
   {
     // Erst das Parent zeichnen, damit wir anschliessend die

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/SelectConfigDialog.java b/src/de/willuhn/jameica/hbci/passports/ddv/SelectConfigDialog.java
@@ -43,9 +43,7 @@ public SelectConfigDialog(int position)
     setTitle(i18n.tr("Auswahl der Kartenleser-Konfiguration"));
   }
 
-  /**
-   * @see de.willuhn.jameica.gui.dialogs.AbstractDialog#paint(org.eclipse.swt.widgets.Composite)
-   */
+  @Override
   protected void paint(Composite parent) throws Exception
   {
     LabelGroup group = new LabelGroup(parent,i18n.tr("Konfiguration"));
@@ -69,6 +67,7 @@ public void handleAction(Object context) throws ApplicationException
 
     ButtonArea buttons = new ButtonArea();
     buttons.addButton(i18n.tr("Übernehmen"), new Action() {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         selected = (DDVConfig) table.getSelection();
@@ -78,6 +77,7 @@ public void handleAction(Object context) throws ApplicationException
       }
     },null,true);
     buttons.addButton(i18n.tr("Abbrechen"), new Action() {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         throw new OperationCanceledException();
@@ -95,9 +95,7 @@ public void setText(String text)
     this.text = text;
   }
 
-  /**
-   * @see de.willuhn.jameica.gui.dialogs.AbstractDialog#getData()
-   */
+  @Override
   protected Object getData() throws Exception
   {
     return selected;

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/View.java b/src/de/willuhn/jameica/hbci/passports/ddv/View.java
@@ -28,9 +28,7 @@ public class View extends AbstractView
 {
   private final static I18N i18n = Application.getPluginLoader().getPlugin(HBCI.class).getResources().getI18N();
 
-  /**
-   * @see de.willuhn.jameica.gui.AbstractView#bind()
-   */
+  @Override
   public void bind() throws Exception
   {
     GUI.getView().setTitle(i18n.tr("Chipkarten-Konfigurationen"));
@@ -45,13 +43,15 @@ public void bind() throws Exception
     ButtonArea buttons = new ButtonArea();
     buttons.addButton(i18n.tr("Kartenleser suchen..."), new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleScan();
       }
     },null,false,"system-search.png");
     buttons.addButton(i18n.tr("Kartenleser manuell anlegen"),new Action()
     {
+      @Override
       public void handleAction(Object context) throws ApplicationException
       {
         control.handleCreate();

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/server/AbstractKaanReader.java b/src/de/willuhn/jameica/hbci/passports/ddv/server/AbstractKaanReader.java
@@ -19,9 +19,7 @@
  */
 public abstract class AbstractKaanReader extends AbstractReader
 {
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getCTAPIDriver()
-   */
+  @Override
   public String getCTAPIDriver()
   {
     switch (Application.getPlatform().getOS())
@@ -49,9 +47,7 @@ public String getCTAPIDriver()
     }
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#isSupported()
-   */
+  @Override
   public boolean isSupported()
   {
     int os = Application.getPlatform().getOS();
@@ -60,9 +56,7 @@ public boolean isSupported()
            os == Platform.OS_LINUX_64;
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#useSoftPin()
-   */
+  @Override
   public boolean useSoftPin()
   {
     return false;

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/server/AbstractReader.java b/src/de/willuhn/jameica/hbci/passports/ddv/server/AbstractReader.java
@@ -99,57 +99,43 @@ File getCTAPIDriverPath()
 
 	}
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getPort()
-   */
+  @Override
   public String getPort()
   {
     return "COM2/USB2";
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getCTNumber()
-   */
+  @Override
   public int getCTNumber()
   {
     return 0;
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#useSoftPin()
-   */
+  @Override
   public boolean useSoftPin()
   {
     return false;
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getType()
-   */
+  @Override
   public Type getType()
   {
     return Type.DDV_CTAPI;
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getDefaultHBCIVersion()
-   */
+  @Override
   public String getDefaultHBCIVersion()
   {
     return HBCIVersion.HBCI_300.getId();
   }
 
-  /**
-   * @see java.lang.Object#toString()
-   */
+  @Override
   public String toString()
   {
     return this.getName();
   }
 
-  /**
-   * @see java.lang.Object#equals(java.lang.Object)
-   */
+  @Override
   public boolean equals(Object obj)
   {
     if (!(obj instanceof Reader))

diff --git a/src/de/willuhn/jameica/hbci/passports/ddv/server/CherrySmartboardReader.java b/src/de/willuhn/jameica/hbci/passports/ddv/server/CherrySmartboardReader.java
@@ -20,17 +20,13 @@
  */
 public class CherrySmartboardReader extends AbstractReader
 {
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getName()
-   */
+  @Override
   public String getName()
   {
     return "CTAPI: Cherry Smartboard";
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#getCTAPIDriver()
-   */
+  @Override
   public String getCTAPIDriver()
   {
     switch (Application.getPlatform().getOS())
@@ -43,9 +39,7 @@ public String getCTAPIDriver()
     }
   }
 
-  /**
-   * @see de.willuhn.jameica.hbci.passports.ddv.rmi.Reader#isSupported()
-   */
+  @Override
   public boolean isSupported()
   {
     return Application.getPlatform().getOS() == Platform.OS_WINDOWS;