Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bilinear basis function #138

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

nataliakeles
Copy link
Contributor

I have implemented a new basis function for the SyIdentPy library: the Bilinear Basis Function. This function is a subcase of NARMAX Polynomial Models.

For additional context, the Bilinear Basis Function is based on the method described in the following paper: Bilinear Basis Function Method - IJC 1989. This method is well-documented and has proven effective in various system identification tasks.

As the next step, I plan to develop comprehensive test functions to ensure the robustness and accuracy of the new implementation.

Please review the changes and provide any feedback.

@wilsonrljr wilsonrljr self-assigned this Sep 2, 2024
Copy link
Owner

@wilsonrljr wilsonrljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nataliakeles,

Thank you so much for your awesome pull request! The Bilinear basis function you've implemented looks solid and is a great addition to the SysIdentPy. I really appreciate the effort you've put into this.

I've gone ahead and accepted the pull request since everything looks great on my end. The only thing left is to add some tests to ensure everything is covered. When you have the chance, it would be great if you could submit a follow-up pull request with the tests included.

Thanks again for your contribution. It's truly appreciated, and I'm excited to see more of your work in the future

@wilsonrljr wilsonrljr merged commit 57e3a27 into wilsonrljr:master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants