Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: a pre-commit hook test for deb-get #871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seefood
Copy link
Contributor

@seefood seefood commented Aug 30, 2023

If accepted, I'll also commit a fix of the current files.

@philclifford
Copy link
Member

I like this. It does have implications for contributors' systems and workflows as well as potentially improving quality and consistency so needs a bit of testing and discussion and probably some notes in the contribution guide (which needs updating anyway...).
Even if it is not finally accepted and merged I'm pretty sure I'll be retaining and maybe extending these suggestions locally in this and other projects so thanks again for the incentive to explore another area of git and foss magic.

@flexiondotorg
Copy link
Member

I like this idea. I wonder if a better place for these checks might be GitHub actions.

@philclifford
Copy link
Member

I think it is preferable to have these checks done pre-commit as they help keep all forks clean and shiny. I do have concerns though that imposing shellcheck on contributorssystems and workflow might be something better handled in a repository workflow. But then even that simply imposes the installation and use ofshellcheck` on contributors without facilitating that for them, so I end up accepting pre-commit as the place to do this.

The key for me is accompanying guidance for contributors.

@seefood
Copy link
Contributor Author

seefood commented Oct 19, 2023

Fair enough. I'm all for checks at the IDE level, pre-commit level and the github actions, they each have their function in the workflow.
As for documentation updates, I'll try to get to all that. I'm just a little pre-occupied here with the war efforts in Israel. May take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants