Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide settings (#9) #10

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Add hide settings (#9) #10

merged 5 commits into from
Mar 27, 2021

Conversation

koolskateguy89
Copy link
Contributor

This solves #9, it only makes sense to have settings to hide the runner & percentage right?

  • Hide runner: (runcat in the middle)
    hide runner

  • Hide percentage:
    hide percentage

@koolskateguy89
Copy link
Contributor Author

The only problem is that the number on the right of the slider/scale isn't in line with the end of the switches :/

@win0err
Copy link
Owner

win0err commented Feb 28, 2021

@koolskateguy89, thank you, awesome work!
I'll do some redesign of the settings window, don't worry about it.

I think that we shouldn't allow hiding both runner and percentage. I think it's quite strange.
Maybe it's better to use ComboBox selector?
Screenshot from 2021-02-28 16-18-22

@koolskateguy89
Copy link
Contributor Author

Yeah that is definitely a better implementation, I'll work on it in a bit

@koolskateguy89
Copy link
Contributor Author

I've implemented the comboBox, I had some difficulty making the code very clear, so I included 2 options of how to implement changing settings:

I think the second options is clearer

runcat_combo

@win0err
Copy link
Owner

win0err commented Mar 1, 2021

Switch case of comboBox active index then changing settings accordingly

Agree, it's more clearer

@win0err win0err added the enhancement New feature or request label Mar 2, 2021
@win0err win0err linked an issue Mar 2, 2021 that may be closed by this pull request
@win0err
Copy link
Owner

win0err commented Mar 3, 2021

@koolskateguy89,
I'll check that new feature works fine on GNOME 3.34, 3.36, 3.38, and 3.40, and then merge the PR

@win0err win0err merged commit ec3ca9a into win0err:master Mar 27, 2021
dev-hann added a commit to dev-hann/gnome-runcat that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add settings to hide percentage & hide runner in Preferences window
2 participants