Maintain consistent widget width #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batwam
changed the title
|
Closing the PR as it is not being reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As mentioned on a previously cancelled PR, the widget changes width when the % drops below 10, making the panel icons around it move around. Rather than manually adding some spaces to the label value as I did before, I tried to implement a neater CSS based solution here to set a fixed width, combined with right alignment for the text and some padding to keep the text away from the adjacent icons.
Please have a look and let me know what you think. I'm not really an expert with setting dimensions with the various notations between numbers, em or pixel values but I figures that the em ratio would be the more appropriate to make sure it's proportional to the font size. 2.0em was leading to the width being too short with font scaling >1.1. I tested a width of 2.1em and had no issue even if I tripled the font size.
Btw, I also test with % only or icon only and they also look fine.
before:
after:
