Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleeping settings #6

Merged
merged 17 commits into from
Nov 20, 2020
Merged

Add sleeping settings #6

merged 17 commits into from
Nov 20, 2020

Conversation

bouteillerAlan
Copy link
Contributor

@bouteillerAlan bouteillerAlan commented Nov 13, 2020

now the settings allow the user to change the minimum value of the cpu usage that make the cat sleep

link to #5 (i see the issues after :') )

Screenshot from 2020-11-13 14-14-08

@win0err win0err added the enhancement New feature or request label Nov 13, 2020
@win0err win0err linked an issue Nov 13, 2020 that may be closed by this pull request
@win0err
Copy link
Owner

win0err commented Nov 13, 2020

@bouteillerAlan, thank you very much for your contribution!
Great work!

I'll leave some feedback according to these changes.

Copy link
Owner

@win0err win0err left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any questions -- feel free to ask!

src/panelMenuButton.js Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/settings.js Outdated Show resolved Hide resolved
src/settings.js Show resolved Hide resolved
src/panelMenuButton.js Outdated Show resolved Hide resolved
src/prefs.js Outdated Show resolved Hide resolved
@bouteillerAlan
Copy link
Contributor Author

bouteillerAlan commented Nov 20, 2020

Hi @win0err , I made some changes.
I'm pretty "new" to the world of gnome extensions, so your review helped me out a lot, thanks!

I think i wouldn't have time to update the pref.js, i'm trying to see if i can update this weekend if not can you do it?

I used this document for help, do you have any other resource to share with me which could be more "recent" to do this correctly?

@win0err
Copy link
Owner

win0err commented Nov 20, 2020

I used this document for help, do you have any other resource to share with me which could be more "recent" to do this correctly?

Documentation is a bit outdated, I recommend you to read about the basics and then take a look at GNOME Shell sources.

  1. GNOME Docs:
  2. GNOME Shell extensions on GitLab
  3. GNOME Shell UI sources

Useful docs:

  1. GJS+GTK3
  2. GJS docs

And I strongly recommend you to use ts-for-gjs to have some kind of autocomplete

.gitignore Outdated Show resolved Hide resolved
src/panelMenuButton.js Outdated Show resolved Hide resolved
bouteillerAlan and others added 2 commits November 20, 2020 15:42
Co-authored-by: Sergei Kolesnikov <win0err@gmail.com>
Co-authored-by: Sergei Kolesnikov <win0err@gmail.com>
@bouteillerAlan
Copy link
Contributor Author

bouteillerAlan commented Nov 20, 2020

Documentation is a bit outdated, I recommend you to read about the basics and then take a look at GNOME Shell sources.

Yeah i have this impression too haha :)

Thanks for the resources, I check that !

@win0err win0err merged commit c9e8054 into win0err:master Nov 20, 2020
@win0err
Copy link
Owner

win0err commented Nov 20, 2020

Thanks for the resources, I check that !

The most important link about super-weird object inheritance in GJS: https://gjs.guide/guides/gjs/transition.html#extending-gobject-classes

@bouteillerAlan bouteillerAlan deleted the feat-settings branch November 23, 2020 08:12
dev-hann added a commit to dev-hann/gnome-runcat that referenced this pull request Sep 18, 2023
- Add extension settings widget
- Add sleeping threshold settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A "sleeping" threshold
2 participants