Skip to content

Commit

Permalink
Fix invalid regex (#115)
Browse files Browse the repository at this point in the history
* Update Roxygen
* Specify encoding to fix CRAN error
* Jump to v0.9.4
  • Loading branch information
zsteinmetz authored Jul 5, 2022
1 parent 9411934 commit 8325df4
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 11 deletions.
8 changes: 4 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: OpenSpecy
Type: Package
Title: Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
Version: 0.9.3
Date: 2021-10-13
Title: Analyze, Process, Identify, and Share Raman and (FT)IR Spectra
Version: 0.9.4
Date: 2022-07-04
Authors@R: c(person("Win", "Cowger", role = c("cre", "aut"),
email = "wincowger@gmail.com",
comment = c(ORCID = "0000-0001-9226-3104")),
Expand Down Expand Up @@ -70,5 +70,5 @@ Suggests:
rdrop2,
mongolite,
loggit
RoxygenNote: 7.1.2
RoxygenNote: 7.2.0
Config/testthat/edition: 3
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# OpenSpecy 0.9.4

## Minor Improvements

- UI improvements
- Gitter support

## Bug Fixes

- Fixed invalid regex failing CRAN checks


# OpenSpecy 0.9.3

## Minor Improvements
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Open Specy

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
Analyze, Process, Identify, and Share Raman and (FT)IR Spectra

<!-- badges: start -->
[![CRAN version](https://www.r-pkg.org/badges/version/OpenSpecy)](https://CRAN.R-project.org/package=OpenSpecy)
Expand Down Expand Up @@ -105,5 +105,5 @@ Needs an Open Source Community: Open Specy to the Rescue!”
[10.1021/acs.analchem.1c00123](https://doi.org/10.1021/acs.analchem.1c00123).

Cowger W, Steinmetz Z (2021). “OpenSpecy: Analyze, Process,
Identify, and Share, Raman and (FT)IR Spectra.” *R package*, **0.9.3**.
Identify, and Share Raman and (FT)IR Spectra.” *R package*, **0.9.4**.
[https://github.com/wincowgerDEV/OpenSpecy](https://github.com/wincowgerDEV/OpenSpecy).
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Test environments

* local Linux/5.14.10-1-MANJARO, R-4.1.1
* manjaro linux 5.18.6-1 (local), R-4.2.1
* macOS latest (via GitHub Actions), R-release
* ubuntu latest (via GitHub Actions), R-devel
* ubuntu latest (via GitHub Actions), R-release
Expand Down
4 changes: 2 additions & 2 deletions man/OpenSpecy-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion man/share_spec.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion tests/testthat/test-read_spec.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ test_that("read_spa() gives expected output", {

test_that("read_jdx() gives expected output", {
expect_match(capture_messages(
suppressWarnings(jdx <- read_jdx(read_extdata("fitr_nitrocellulose.jdx")))
suppressWarnings(jdx <- read_jdx(read_extdata("fitr_nitrocellulose.jdx"),
encoding = "latin1"))
), "JDX file inconsistency.*"
)
expect_error(read_jdx(read_extdata("throws_error_raman_1000002.jdx")))
Expand Down

0 comments on commit 8325df4

Please sign in to comment.