Skip to content

Commit

Permalink
fix: playbook files permission mode incompatible with Windows (#4740)
Browse files Browse the repository at this point in the history
  • Loading branch information
wendrul authored Nov 18, 2024
1 parent ee9d3e0 commit 4d9ec90
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions backend/windmill-common/src/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,18 @@ pub fn write_file_at_user_defined_location(

let mut file = File::create(full_path)?;

#[cfg(unix)]
if let Some(mode) = mode {
let perm = std::os::unix::fs::PermissionsExt::from_mode(mode);
file.set_permissions(perm)
.map_err(|e| anyhow!("Failed to set permissions to {}: {e}", user_defined_path))?;
}

#[cfg(windows)]
if mode.is_some() {
tracing::error!("Cannot use `mode` to set file permissions on windows workers");
}

file.write_all(content.as_bytes())?;
file.flush()?;
Ok(normalized_full_path)
Expand Down

0 comments on commit 4d9ec90

Please sign in to comment.