Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playbook files permission mode incompatible with Windows #4740

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: playbook files permission mode incompatible with Windows #4740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01af6ce
fix: playbook files permission mode incompatible with Windows
wendrul Nov 18, 2024
1a01dc6
Merge branch 'main' into win-672-fix-windows-not-accepting-permission…
wendrul Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/windmill-common/src/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,18 @@ pub fn write_file_at_user_defined_location(

let mut file = File::create(full_path)?;

#[cfg(unix)]
if let Some(mode) = mode {
let perm = std::os::unix::fs::PermissionsExt::from_mode(mode);
file.set_permissions(perm)
.map_err(|e| anyhow!("Failed to set permissions to {}: {e}", user_defined_path))?;
}

#[cfg(windows)]
if mode.is_some() {
tracing::error!("Cannot use `mode` to set file permissions on windows workers");
}

file.write_all(content.as_bytes())?;
file.flush()?;
Ok(normalized_full_path)
Expand Down
Loading