Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: captures #4807

Merged
merged 69 commits into from
Jan 6, 2025
Merged

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Nov 27, 2024

Important

Add capture handling feature with backend SQL and API updates, and frontend UI enhancements.

  • Backend:
    • Add new SQL queries for handling capture configurations in .sqlx files.
    • Update existing queries to support new capture functionality.
    • Modify API endpoints in openapi.yaml to handle capture configurations.
    • Implement new functions in capture.rs for setting and pinging capture configurations.
  • Frontend:
    • Update FlowEditorPanel.svelte and ScriptEditor.svelte to handle capture-related actions.
    • Add new components like CaptureButton.svelte and CaptureTable.svelte for UI interactions.
    • Modify svelte.config.js to include preprocessMeltUI for UI enhancements.
    • Update context in +page.svelte to include capture-related states.

This description was created by Ellipsis for ffdab59. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: ffdab59
Status: ✅  Deploy successful!
Preview URL: https://ba223d08.windmill.pages.dev
Branch Preview URL: https://hugo-win-423-http-triggerspr.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel force-pushed the main branch 6 times, most recently from f85cf46 to 2c5d07f Compare December 9, 2024 17:02
@rubenfiszel rubenfiszel force-pushed the main branch 2 times, most recently from 4ea13d3 to 95c613d Compare December 17, 2024 10:06
@HugoCasa HugoCasa marked this pull request as ready for review January 5, 2025 11:21
@HugoCasa HugoCasa requested a review from rubenfiszel as a code owner January 5, 2025 11:21
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to ffdab59 in 2 minutes and 54 seconds

More details
  • Looked at 9524 lines of code in 102 files
  • Skipped 2 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. backend/windmill-api/src/capture.rs:12
  • Draft comment:
    Verify that increasing KEEP_LAST from 8 to 20 aligns with system capacity and intended behavior.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The KEEP_LAST constant was changed from 8 to 20, which affects the number of recent captures retained. This change should be verified to ensure it aligns with the intended behavior and system capacity.
2. frontend/src/lib/components/details/CopyableCodeBlock.svelte:1
  • Draft comment:
    This functionality already exists in HighlightCode. Consider using or extending that component instead.

  • component HighlightCode (HighlightCode.svelte)

  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    While there is overlap in functionality, CopyableCodeBlock appears to serve a different specific use case with its disabled state and simpler interface. The differences seem intentional rather than accidental duplication. Forcing reuse here could make the code more complex rather than better.
    The comment raises a valid point about code reuse and DRY principles. Having two components that both wrap svelte-highlight with copy functionality could lead to maintenance issues.
    Sometimes having two simpler, focused components is better than one complex component. The differences here seem intentional and trying to force reuse could add unnecessary complexity.
    While the comment raises a valid point about potential code duplication, the differences between the components appear intentional and valuable. The comment should be removed as it wouldn't lead to better code.

Workflow ID: wflow_2djoEnFKpWYgnD1J


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -0,0 +1,55 @@
<script lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the existing Section component. The components are functionally identical with only cosmetic differences. Consider using Section with small=true instead of creating a new component.

@rubenfiszel rubenfiszel merged commit 01c6f84 into main Jan 6, 2025
8 checks passed
@rubenfiszel rubenfiszel deleted the hugo/win-423-http-triggerspreprocessor-capture branch January 6, 2025 11:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants