Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend(ee): pass cargo check #4949

Merged
merged 1 commit into from
Dec 18, 2024
Merged

backend(ee): pass cargo check #4949

merged 1 commit into from
Dec 18, 2024

Conversation

uael
Copy link
Collaborator

@uael uael commented Dec 18, 2024

Important

Update feature flags and dependencies to pass cargo check in the enterprise edition.

  • Features:
    • Add oauth2 to enterprise_saml and enterprise to stripe in backend/Cargo.toml.
    • Add enterprise and parquet to tantivy feature in backend/Cargo.toml.
  • Dependencies:
    • Remove mime_guess from static_frontend in windmill-api/Cargo.toml.
    • Make mime_guess non-optional in windmill-api/Cargo.toml.
  • Conditional Compilation:
    • Update SCHEDULE_RECOVERY_HANDLER_USER_EMAIL to be available under enterprise or cloud feature in jobs.rs.

This description was created by Ellipsis for 6cb32f3. It will automatically update as commits are pushed.

@rubenfiszel rubenfiszel marked this pull request as ready for review December 18, 2024 15:20
@rubenfiszel rubenfiszel self-requested a review as a code owner December 18, 2024 15:20
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6cb32f3 in 21 seconds

More details
  • Looked at 71 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-queue/src/jobs.rs:123
  • Draft comment:
    The feature configuration for SCHEDULE_RECOVERY_HANDLER_USER_EMAIL is now correctly using any(feature = "enterprise", feature = "cloud"), which is consistent with the intent to include this constant for both enterprise and cloud features.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The feature configuration for SCHEDULE_RECOVERY_HANDLER_USER_EMAIL is now correctly using any(feature = "enterprise", feature = "cloud"), which is consistent with the intent to include this constant for both enterprise and cloud features.

Workflow ID: wflow_Byd10hfvtdJqoicl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 0ee3a77 into main Dec 18, 2024
7 checks passed
@rubenfiszel rubenfiszel deleted the uael/cargo_check branch December 18, 2024 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants