prevent cancelling schedule next tick + remove need of flow_status inside add_completed_job

[HugoCasa]

Important

Prevents cancelling future scheduled jobs and refines next tick scheduling logic using a new SQL query in jobs.rs.

• Behavior:
  • Prevents cancelling future scheduled jobs in cancel_job() by checking if scheduled_for is greater than current time.
  • Refines logic in add_completed_job() to determine when to schedule the next tick using a new SQL query.
• SQL:
  • Adds new SQL query in .sqlx/query-e4e87539ae18f7e5c6bd9a28d16b7527ececad87d218182ff723e6a6c43ecd50.json to check flow status conditions for scheduling.
• Misc:
  • Imports now_from_db in jobs.rs for time comparison.

^{This description was created by for 45b845d. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 45b845d in 30 seconds

More details

• Looked at 110 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. backend/windmill-queue/src/jobs.rs:236

• Draft comment:
  Typo in error message: 'direcly' should be 'directly'.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The error message in the cancel_job function contains a typo. The word 'direcly' should be 'directly'. This is a minor issue but should be corrected for clarity and professionalism.

2. backend/windmill-queue/src/jobs.rs:742

• Draft comment:
  Consider using Uuid::nil().to_string() directly in the query to avoid potential issues with string representation.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The SQL query in add_completed_job function is using a hardcoded string for Uuid::nil(). It would be better to use Uuid::nil().to_string() directly in the query to avoid potential issues with string representation.

Workflow ID: wflow_acSPto2tstr8knVY

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	45b845d
Status:	✅  Deploy successful!
Preview URL:	https://79514092.windmill.pages.dev
Branch Preview URL:	https://hc-prevent-cancelling-schedu.windmill.pages.dev

View logs