fix workspace color picker issue

[alpetric]

Important

Fixes workspace color picker initialization and logic in ChangeWorkspaceColor.svelte.

• Behavior:
  • Fixes initialization of workspaceColor in ChangeWorkspaceColor.svelte to correctly fetch from $usersWorkspaceStore.
  • Adjusts logic to ensure generateRandomColor() is called only when colorEnabled is true and workspaceColor is not set.
• State Management:
  • Ensures workspaceColor is updated after saving changes in changeWorkspaceColor() function.

^{This description was created by for 8d6fd37. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 8d6fd37 in 1 minute and 36 seconds

More details

• Looked at 28 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte:15

• Draft comment:
  The reactive statement $: workspaceColor is unnecessary and can be removed as it doesn't perform any operations.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The reactive statement for workspaceColor is unnecessary since it doesn't perform any operations. It can be removed to clean up the code.

2. frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte:16

• Draft comment:
  Ensure workspaceColor is reactive when modified by generateRandomColor to avoid unexpected behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The generateRandomColor function is called in a reactive statement, but it doesn't update any reactive variables directly. This could lead to unexpected behavior if workspaceColor is not properly tracked. Consider ensuring workspaceColor is reactive or refactor the logic.

3. frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte:38

• Draft comment:
  Ensure workspaceColor is not set to undefined to prevent potential issues. Consider handling the case where colorToSave is undefined.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The changeWorkspaceColor function sets workspaceColor to colorToSave, which can be undefined. This might lead to issues if workspaceColor is expected to always be a valid color string elsewhere in the code.

Workflow ID: wflow_M60gBvCgZTNrblrh

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	8d6fd37
Status:	✅  Deploy successful!
Preview URL:	https://20f9334d.windmill.pages.dev
Branch Preview URL:	https://alp-ws-color-fix.windmill.pages.dev

View logs

[hcourdent]

Works on my chrome