Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace color fixes part2 #5045

Merged
merged 5 commits into from
Jan 10, 2025
Merged

workspace color fixes part2 #5045

merged 5 commits into from
Jan 10, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 10, 2025

  • using full width across all browsers for workspace list in menu bar (was different behavior between firefox and chrome/safari)
  • correctly update userWorkspaceStore when switching workspaces

Important

Fix workspace list width across browsers and update userWorkspaceStore correctly when switching workspaces.

  • Behavior:
    • Ensure full-width display of workspace list in WorkspaceMenu.svelte across all browsers.
    • Update userWorkspaceStore correctly when switching workspaces in ChangeWorkspaceColor.svelte.
  • UI:
    • Add min-w-0 w-full to workspace list items in WorkspaceMenu.svelte for consistent width.
    • Use savedWorkspaceColor instead of workspaceColor for display in ChangeWorkspaceColor.svelte.
    • Conditionally render color input in ChangeWorkspaceColor.svelte based on colorEnabled.

This description was created by Ellipsis for 60523fa. It will automatically update as commits are pushed.

@alpetric alpetric requested a review from rubenfiszel as a code owner January 10, 2025 18:32
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 60523fa in 41 seconds

More details
  • Looked at 74 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte:45
  • Draft comment:
    Consider updating savedWorkspaceColor in generateRandomColor to ensure consistency between the displayed color and the saved color.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. frontend/src/lib/components/sidebar/WorkspaceMenu.svelte:80
  • Draft comment:
    Consider updating the userWorkspaces store after switching workspaces to ensure the UI reflects the current state.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_blqjGcnG1Pr7OJzw


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 089e698 into main Jan 10, 2025
6 of 7 checks passed
@rubenfiszel rubenfiszel deleted the alp/ws_color_fix branch January 10, 2025 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants