-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: msft teams support for critical alerts #5113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying windmill with Cloudflare Pages
|
alpetric
changed the title
feat: msft teams support for critical alerts
[WIP] feat: msft teams support for critical alerts
Jan 22, 2025
needs ee merge first for ee_full to pass |
alpetric
changed the title
[WIP] feat: msft teams support for critical alerts
feat: msft teams support for critical alerts
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5738fdb in 1 minute and 20 seconds
More details
- Looked at
836
lines of code in29
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. backend/migrations/20250115223046_teams_global_settings.down.sql:1
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
2. backend/migrations/20250115223046_teams_global_settings.up.sql:1
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
3. backend/windmill-api/src/teams_ee.rs:5
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
4. backend/.sqlx/query-08dd2ea6b17a52bce352d6443d7d009cfc9da0d3b2bd1f40d422b550779e5324.json:20
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
5. backend/.sqlx/query-44a12919fb154055f1142cc078ef131f8a0c9cdb37cfba6283a6718480b02a4b.json:34
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
6. backend/.sqlx/query-84d048ea323758842dc564c700b524d1a5b196a7b77afcb02f46b84b22088bbf.json:20
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
7. backend/.sqlx/query-9c72b2962d0919353cfe5af710e857d432dff44e343b8f0610208d42ff5afd14.json:14
- Draft comment:
Add a newline at the end of the file for better POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
Workflow ID: wflow_cNikAoiU3TkuHtSo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds Microsoft Teams support for critical alerts, including backend API endpoints, database migrations, and frontend UI components for configuration.
/teams/sync
inopenapi.yaml
for synchronizing Teams information..sqlx/query-*.json
files.20250115223046_teams_global_settings.up.sql
and20250115223046_teams_global_settings.down.sql
for Teams settings.main.rs
to handle Teams settings changes.teams_ee.rs
for Teams service routing.oauth2_ee.rs
to include Teams in OAuth client building.AuthSettings.svelte
,InstanceSetting.svelte
, andOAuthSetting.svelte
to include Teams in OAuth settings.InstanceSettings.svelte
to handle Teams in critical alert channels.IconedResourceType.svelte
to include Teams icon.This description was created by for 5738fdb. It will automatically update as commits are pushed.