Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: msft teams support for critical alerts #5113

Merged
merged 12 commits into from
Jan 23, 2025
Merged

feat: msft teams support for critical alerts #5113

merged 12 commits into from
Jan 23, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 22, 2025

Important

Adds Microsoft Teams support for critical alerts, including backend API endpoints, database migrations, and frontend UI components for configuration.

  • Behavior:
    • Adds support for Microsoft Teams in critical alerts, allowing configuration of Teams channels for alert notifications.
    • Introduces new API endpoint /teams/sync in openapi.yaml for synchronizing Teams information.
  • Database:
    • Adds new SQL queries for handling Teams settings in .sqlx/query-*.json files.
    • Adds migration scripts 20250115223046_teams_global_settings.up.sql and 20250115223046_teams_global_settings.down.sql for Teams settings.
  • Backend:
    • Updates main.rs to handle Teams settings changes.
    • Adds teams_ee.rs for Teams service routing.
    • Modifies oauth2_ee.rs to include Teams in OAuth client building.
  • Frontend:
    • Updates AuthSettings.svelte, InstanceSetting.svelte, and OAuthSetting.svelte to include Teams in OAuth settings.
    • Modifies InstanceSettings.svelte to handle Teams in critical alert channels.
    • Updates IconedResourceType.svelte to include Teams icon.

This description was created by Ellipsis for 5738fdb. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5738fdb
Status: ✅  Deploy successful!
Preview URL: https://b0ce2d6e.windmill.pages.dev
Branch Preview URL: https://alp-msft-teams.windmill.pages.dev

View logs

@alpetric alpetric changed the title feat: msft teams support for critical alerts [WIP] feat: msft teams support for critical alerts Jan 22, 2025
@alpetric
Copy link
Contributor Author

needs ee merge first for ee_full to pass

@alpetric alpetric changed the title [WIP] feat: msft teams support for critical alerts feat: msft teams support for critical alerts Jan 23, 2025
@alpetric alpetric marked this pull request as ready for review January 23, 2025 18:50
@alpetric alpetric requested a review from rubenfiszel as a code owner January 23, 2025 18:50
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5738fdb in 1 minute and 20 seconds

More details
  • Looked at 836 lines of code in 29 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. backend/migrations/20250115223046_teams_global_settings.down.sql:1
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
2. backend/migrations/20250115223046_teams_global_settings.up.sql:1
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
3. backend/windmill-api/src/teams_ee.rs:5
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
4. backend/.sqlx/query-08dd2ea6b17a52bce352d6443d7d009cfc9da0d3b2bd1f40d422b550779e5324.json:20
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
5. backend/.sqlx/query-44a12919fb154055f1142cc078ef131f8a0c9cdb37cfba6283a6718480b02a4b.json:34
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
6. backend/.sqlx/query-84d048ea323758842dc564c700b524d1a5b196a7b77afcb02f46b84b22088bbf.json:20
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.
7. backend/.sqlx/query-9c72b2962d0919353cfe5af710e857d432dff44e343b8f0610208d42ff5afd14.json:14
  • Draft comment:
    Add a newline at the end of the file for better POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code is missing a newline at the end of the file, which is a common best practice for POSIX compliance and to avoid potential issues with some tools.

Workflow ID: wflow_cNikAoiU3TkuHtSo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit a88fbb2 into main Jan 23, 2025
8 checks passed
@rubenfiszel rubenfiszel deleted the alp/msft_teams branch January 23, 2025 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants