feat: history for flow inputs #5117
Conversation
# Conflicts: # frontend/src/lib/components/ArgInput.svelte
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3d8e7ed in 1 minute and 28 seconds
More details
- Looked at
2122lines of code in28files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/lib/components/schema/SchemaPickerRow.svelte:85
- Draft comment:
Ensure consistent handling of 'WINDMILL_TOO_BIG' payloads across all components that process payloads. - Reason this comment was not posted:
Confidence changes required:50%
The code inSchemaPickerRow.sveltehas a potential issue with handling large payloads. The condition for 'WINDMILL_TOO_BIG' is correctly handled, but it's important to ensure that this condition is consistently checked wherever payloads are processed.
2. frontend/src/lib/components/meltComponents/Popover.svelte:32
- Draft comment:
Consider debouncing themouseenterandmouseleaveevents to prevent rapid state changes. - Reason this comment was not posted:
Confidence changes required:50%
The code inPopover.sveltehas a potential issue with theopenOnHoverfunctionality. Themouseenterandmouseleaveevents directly modify theopenstate, which might lead to unexpected behavior if the state is also controlled externally.
Workflow ID: wflow_HKN3UDGaFSc8nCbp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7d0af65 in 44 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/SchemaFormWithArgPicker.svelte:102
- Draft comment:
Typo in event type. Change 'histroy' to 'history'.
dispatch('select', { payload: e.detail, type: 'history' })
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_3ksjMUwzYZb1NuaJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ff6e3f6 in 52 seconds
More details
- Looked at
150lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/lib/components/triggers/CaptureTable.svelte:83
- Draft comment:
Avoid usingconsole.logfor debugging in production code. Consider using a proper logging mechanism or remove it if not needed. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
While console.log statements generally shouldn't be in production code, this one appears to be intentionally logging a specific condition (WINDMILL_TOO_BIG) that might be useful for debugging in production. However, a proper logging mechanism would be better. The comment is technically correct but may be too minor of an issue to warrant a PR comment.
The console.log might actually be intentional for monitoring this edge case in production. Also, this is a relatively minor code quality issue that doesn't affect functionality.
While the logging could be intentional, using console.log is still not best practice and a proper logging system would be better. However, this feels too minor for a PR comment.
While technically correct, this comment is too minor and doesn't warrant blocking or modifying the PR. The console.log, while not ideal, isn't causing any real issues.
2. frontend/src/lib/components/triggers/CaptureTable.svelte:146
- Draft comment:
Consider checking the type ofcapture.payloadDatabefore usingstructuredCloneto avoid unnecessary cloning if it's already a simple object. - Reason this comment was not posted:
Confidence changes required:50%
ThegetPayloadfunction usesstructuredCloneoncapture.payloadData, which might be unnecessary ifcapture.payloadDatais already a simple object. This could be optimized by checking the type before cloning.
3. frontend/src/lib/components/triggers/CaptureTable.svelte:130
- Draft comment:
Consider checking the type ofpayloadDatabefore usingstructuredCloneto avoid unnecessary cloning if it's already a simple object. - Reason this comment was not posted:
Confidence changes required:50%
ThehandleSelectfunction usesstructuredCloneonpayloadData, which might be unnecessary ifpayloadDatais already a simple object. This could be optimized by checking the type before cloning.
Workflow ID: wflow_6tcgzhHmFyYPUab7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8a0a174 in 1 minute and 12 seconds
More details
- Looked at
53lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_QvoddDTRXCSBYYQZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3ac03ee in 28 seconds
More details
- Looked at
174lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4LBQYHqmEK6MBxXR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7ce6368 in 22 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/triggers/CaptureTable.svelte:82
- Draft comment:
Removing theconsole.logstatement is a good practice for production code to avoid unnecessary logging. - Reason this comment was not posted:
Confidence changes required:10%
The removal of the console.log statement is appropriate for production code as it avoids unnecessary logging, which can clutter the console and potentially expose sensitive information.
Workflow ID: wflow_3ReH0smxkMuHJMuF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 7a931db in 1 minute and 35 seconds
More details
- Looked at
222lines of code in6files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/lib/components/meltComponents/SideBarTab.svelte:38
- Draft comment:
The class binding syntax is incorrect. Use the correct Svelte syntax for conditional classes.
class="flex flex-col relative !overflow-visible {expandRight ? 'pr-2 -mr-2' : ''}"
- Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/lib/components/SchemaFormWithArgPicker.svelte:132
- Draft comment:
Typo: Correctsvelete:fragmenttosvelte:fragment. This typo appears multiple times in the code. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_7OeGyOj0VFvO65uD
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| <div style="height: {rightHeight}px" class="border-t border-r pb-2"> | ||
| {#if selectedTab === 'history'} | ||
| <FlowInputEditor title="History"> | ||
| <svelete:fragment slot="action"> |
There was a problem hiding this comment.
Typo: Correct svelete:fragment to svelte:fragment. This typo appears multiple times in the code.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 42ae9ff in 24 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/triggers/CaptureTable.svelte:331
- Draft comment:
Consider simplifying the nested ternary operation for thetitleattribute to improve readability.
title={isFlow && testKind === 'main' ? 'Test flow with args' : (testKind === 'preprocessor' ? 'Apply args to preprocessor' : 'Apply args to inputs')}
- Reason this comment was not posted:
Confidence changes required:20%
The code uses a ternary operator for setting the title attribute of a button. The logic is correct, but the readability can be improved by using a single ternary operation instead of nested ones.
Workflow ID: wflow_3znNhyOeufiPE6Ze
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Adds history and saved input management for flows with JSON view and input selection features.
FlowPreviewContent.svelteandFlowStatusViewerInner.svelte.RunForm.svelteandFlowInput.svelte.InputSelectedBadge.svelte.JsonInputs.sveltefor JSON input handling.SavedInputsV2.svelteandSchemaFormWithArgPicker.sveltefor managing saved and historical inputs.FlowPreviewContent.svelteto useSchemaFormWithArgPicker.model.tsfor reuse.Drawer.svelteandDisposable.svelteto handle escape key behavior withpreventEscapeflag.Popover.svelteto support hover-based opening.This description was created by
for 42ae9ff. It will automatically update as commits are pushed.