Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5127

Merged
Merged

Conversation

dieriba
Copy link
Collaborator

@dieriba dieriba commented Jan 24, 2025

Important

Add last_server_ping property to backend schema and update frontend to handle new trigger properties.

  • Backend:
    • Add last_server_ping property to response schema in openapi.yaml.
  • Frontend:
    • Update +page.svelte to include last_server_ping, error, and server_id when updating trigger information.

This description was created by Ellipsis for 1b075c4. It will automatically update as commits are pushed.

@dieriba dieriba requested a review from rubenfiszel as a code owner January 24, 2025 16:05
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1b075c4 in 12 seconds

More details
  • Looked at 30 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/routes/(root)/(logged)/postgres_triggers/+page.svelte:59
  • Draft comment:
    The last_server_ping field is added to the triggers array but is not used elsewhere. Ensure this is intentional or consider removing it if not needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new field last_server_ping to the trigger update logic. This field is added to the triggers array but is not used anywhere else in the code. It might be intended for future use, but currently, it seems unnecessary.

Workflow ID: wflow_UORzRDF3CI7U7PHo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 1eaef85 into main Jan 24, 2025
7 of 8 checks passed
@rubenfiszel rubenfiszel deleted the fix/postgres-trigger-display-connected-without-refresh branch January 24, 2025 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants