-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subtypes #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, looks good overall just have a couple minor requests. 👍
By the way, I'd recommend maybe pinning the Rust version used for clippy linting. In order for CI to pass I had to fix some warning level clippy lints that were introduced in the newest version. |
Hey there - I've been looking into this PR a bit deeper and there are a couple issues I currently see with it:
Bonjour reference: https://developer.apple.com/documentation/dnssd/1804733-dnsserviceregister?language=objc I appreciate you may not have the hardware to implement the Bonjour side of this so I've started a branch to amend your changes. Once I am happy with it I will submit a PR to this branch and then we can merge into main. Thanks for your patience. |
Superseded by #32 |
Resolves #30
Tested, here's a log snippet:
And from avahi-browse (snipped extraneous info):