Normalize consistency of unsafe in function contracts #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walker Crouse <walkercrouse@hotmail.com>
Signed-off-by: Walker Crouse <walkercrouse@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR normalizes the consistency of where the
unsafeboundary is, marking functions of the implementation-level interfacesunsafeif they use unsafe functionality.Why
The goal here is to make the boundary of
unsafemore well defined between implementation-level details and the library-level interfaces that are provided to the end user; and, makes clear that, these implementation-level interfaces do not provide the guarantees that the library-level ones do.Manual Tests
Tested on macOS, Windows, and Linux
Documentation Updates
n/a