Unbreak build on FreeBSD #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 50.77% 50.76% -0.01%
==========================================
Files 941 941
Lines 87404 87404
Branches 45306 45311 +5
==========================================
- Hits 44376 44370 -6
- Misses 38315 38675 +360
+ Partials 4713 4359 -354 ☔ View full report in Codecov by Sentry. |
|
Thanks! Commit message of Also message line limit is 90. |
|
Is this still relevant? It would need to be rebased on current master. |
|
Yes. I'll only rebase if there're merge conflicts but there're none so far.
|
In file included from theseus-ship-6.0.0/main_wayland.cpp:10:
In file included from /usr/include/como/base/wayland/xwl_platform.h:17:
In file included from /usr/include/como/render/wayland/xwl_platform.h:15:
In file included from /usr/include/como/render/post/night_color_manager.h:14:
/usr/include/como/base/os/clock/skew_notifier.h:8:10:
fatal error: 'skew_notifier_engine.h' file not found
8 | #include "skew_notifier_engine.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~
como/xwl/socket.cpp:124:9: error: use of undeclared identifier 'close'
close(fd);
^
como/xwl/socket.cpp:129:9: error: use of undeclared identifier 'close'
close(fd);
^
como/xwl/socket.cpp:155:44: error: use of undeclared identifier 'getuid'
if (info.st_uid != 0 && info.st_uid != getuid()) {
^
como/xwl/socket.cpp:184:17: error: use of undeclared identifier 'close'
close(fd);
^
como/xwl/socket.cpp:223:9: error: use of undeclared identifier 'close'
close(fd);
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.