Fix NVM Node.js PATH issue for locally installed Claude

[humanwritten]

Problem

When opcode is launched from /Applications folder on macOS, it receives a minimal PATH environment that doesn't include NVM directories. This causes Claude commands to fail with "env: node: No such file or directory" for users with npm-local Claude installations that depend on Node.js from NVM.

Root Cause

The existing code had an unused _std_cmd variable in commands/claude.rs that was creating an enhanced PATH but never using it. Additionally, NVM path detection only worked when Claude itself was installed in an NVM directory, not when Claude was elsewhere but needed Node.js from NVM.

Solution

This PR provides a minimal, targeted fix:

1. Fixed unused variable: Removed underscore from _std_cmd so the enhanced PATH is actually used
2. Added NVM detection: Added an else clause in claude_binary.rs to detect and add NVM Node.js paths even when Claude isn't installed via NVM
3. Targeted override: Added a conditional override that ONLY applies when Claude is NOT in NVM but needs Node.js from NVM

Changes

• src-tauri/src/claude_binary.rs: Added else clause for NVM detection when Claude needs Node but isn't in NVM
• src-tauri/src/commands/claude.rs: Fixed unused _std_cmd and added targeted PATH override

Testing

• Built and tested DMG on macOS with Claude installed via npm-local
• Verified the fix works when opcode is launched from /Applications
• The fix only triggers for the specific edge case (Claude not in NVM but needing Node from NVM)
• Note: Tested and confirmed working on macOS where the edge case was occurring. Not tested on other environments or operating systems.

Impact

• Zero impact on other installation types - the override only happens when Claude is NOT in an NVM directory but the enhanced PATH contains NVM paths
• No changes to existing logic flow - all existing code runs first, our fix applies last only when needed
• Platform-safe: NVM path detection only adds paths if they exist

Fixes the issue where npm-local Claude installations fail when opcode is launched from /Applications due to missing Node.js in PATH.

[humanwritten]

Have written about the process of this contribution here: https://humanwritten.ai/os1/

[123vivekr]

Hi, thanks for the PR. I just ran this PR through claude. Can you take a look at these suggestions?

1. Version Sort Algorithm

Current:

node_versions.sort_by(|a, b| b.cmp(a));

Issue: Simple string comparison may not work correctly for all semantic versions:

• v20.10.0 > v20.9.0 ✅ (correct)
• v20.9.0 > v20.10.0 ⚠️ (string comparison puts "9" > "10")

Recommendation: Use semantic version parsing for more robust comparison:

node_versions.sort_by(|a, b| {
    // Parse semantic version (v20.10.0 -> [20, 10, 0])
    let parse_version = |v: &str| {
        v.trim_start_matches('v')
            .split('.')
            .filter_map(|s| s.parse::<u32>().ok())
            .collect::<Vec<u32>>()
    };

    let a_parts = parse_version(a);
    let b_parts = parse_version(b);
    b_parts.cmp(&a_parts)
});

2. Homebrew Node.js Not Considered

Current: Only adds NVM Node.js paths.

Issue: Users may have Node.js installed via Homebrew (/opt/homebrew/bin/node or /usr/local/bin/node), which may also be missing when launched from /Applications.

Recommendation: Consider adding Homebrew paths as fallback:

// After NVM check, also check for Homebrew Node.js
if cfg!(target_os = "macos") {
    let homebrew_paths = vec![
        "/opt/homebrew/bin",
        "/usr/local/bin"
    ];
    for hb_path in homebrew_paths {
        if !current_path.contains(hb_path) {
            let node_check = PathBuf::from(hb_path).join("node");
            if node_check.exists() {
                let new_path = format!("{}:{}", hb_path, current_path);
                cmd.env("PATH", new_path);
                break;
            }
        }
    }
}

3. Duplicate Logic Between Files

Issue: Similar PATH enhancement logic exists in both files (claude_binary.rs:492-535 and claude.rs:279-290).

Recommendation: Consider extracting to a shared helper function to reduce duplication and improve maintainability.

4. Error Handling

Current: Silent failures with filter_map(|entry| entry.ok())

Recommendation: Log errors when directory reading fails:

let mut node_versions: Vec<String> = entries
    .filter_map(|entry| match entry {
        Ok(e) => Some(e),
        Err(err) => {
            log::warn!("Failed to read NVM directory entry: {}", err);
            None
        }
    })
    // ... rest of chain

5. PATH Ordering

Current: Prepends NVM path: format!("{}:{}", node_bin_str, current_path)

Consideration: This gives NVM Node.js highest priority. Verify this is the desired behavior - it will override system Node.js installations.

[humanwritten]

@123vivekr - i actually went through a loop of this but I didn't want to change more than was needed to sort the fix for my NVM specific install issue.

The sort algorithm is fine and fixed my issue which is all that I'm trying to submit.

With regards to the other points they're missing context as homebrew + other conditions already exist throughout the code - I chose purposely not to re-write/refactor these and just to fix my issue as the rest isn't my code.

I went through claude analysis loop too and it suggested making many more changes but i guided it to keep it simple and just solve the specific edge case not impacting other logic.