Skip to content

Commit

Permalink
refactor(sdk): rubocop warnings fixed, code properly linted
Browse files Browse the repository at this point in the history
  • Loading branch information
Abbas-khaliq authored and softvar committed Apr 25, 2022
1 parent 2ee4975 commit 1d897ad
Show file tree
Hide file tree
Showing 40 changed files with 2,017 additions and 2,170 deletions.
13 changes: 13 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@ Metrics/AbcSize:
Max: 100
Metrics/ParameterLists:
Max: 10
MaxOptionalParameters: 5
Metrics/CyclomaticComplexity:
Max: 30
Metrics/PerceivedComplexity:
Max: 30
Metrics/ModuleLength:
Max: 225
Style/RedundantBegin:
Enabled: false
Style/Documentation:
Enabled: false
Style/ZeroLengthPredicate:
Expand All @@ -30,3 +35,11 @@ Style/MutableConstant:
Enabled: false
Style/FrozenStringLiteralComment:
Enabled: false
Style/OptionalBooleanParameter:
AllowedMethods: ['initialize', 'get_variation_if_whitelisting_passed', 'whitelisting_or_storage_for_grouped_campaigns?', 'presegmentation?', 'get_variation_allotted', 'save_user_storage', 'get_stored_variation', 'get_variation_of_campaign_for_user', 'get_user_storage', 'evaluate_whitelisting', 'flush', 'log', 'generator_for', 'evaluate', 'get_settings_file', 'user_part_of_campaign?', 'bucket_user_to_variation', 'get_bucket_value_for_user']
Style/DoubleNegation:
Enabled: false
Style/CombinableLoops:
Enabled: false
Security/JSONLoad:
Enabled: false
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.37.1] - 2022-25-04

### Changed

- Code properly linted, fixed rubocop warnings and errors

## [1.36.0] - 2022-04-04

### Changed

- Fix resolving `vwo_sdk_log_messages` dependency

## [1.35.0] - 2022-03-28
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ source 'http://rubygems.org'

gem 'json-schema', '~>2.8.1'
gem 'murmurhash3', '~>0.1.6'
gem "vwo_log_messages", '~>0.7.4'
gem 'vwo_log_messages', '~>0.7.4'

# gem 'codecov', require: false, group: 'test'
# gem 'rubocop', require: false, group: 'test'
gem 'rubocop', require: false, group: 'test'

group :development, :test do
gem 'mocha', '~> 1.13'
Expand Down
Loading

0 comments on commit 1d897ad

Please sign in to comment.