-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose child
on default logger
#1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always good to have a consistent interface between regular loggers and the default logger.
And... that call-style looks pretty slick :)
Thanks!
Love it, I was just looking for this feature. Ty. Is there an ETA for when this will appear on |
@DABH any ETA on when this will appear in a release? Even a patch would be nice 😬 |
We’ll probably cut a release in a week or two (sorry for vague estimate). In the meantime feel free to reference the master branch directly in your package.json :) Thanks! |
@DABH Any update on this release? |
@DABH Same as above. Any news on cutting a release with this in? |
@DABH Ping! Last release was on 29 Jan. This is non-breaking could we just get a patch with the latest fixes in master? |
You will have to ping @indexzero as I can’t push a new tag to npm unfortunately |
@indexzero could we please get a new version of Winston tagged and released? |
Any update on this? @indexzero ? Issue #1767 is still open as well with no response even though this commit looks to resolve it. |
* Add `child` pass-through to type defs * Add pass-through to defaultLogger.child(...) * Add test for `winston.child` * fix: type defs
This allows use to add child loggers to the default logger.
This makes it easy to establish a pattern for sub-components to scope their logs without needing to call
createLogger
or be passed the application logger.Example:
app.js
component-xyz.js