[Fix] logger.info({message:...}) modifies original object

[debadutta98]

Hi @wbt ,

This PR closes #1775

What is wrong here?

When we copy the original object to a new object it also copies the reference of the original object to avoid this we need to implement deep copy which stores two objects in two different locations.

Work

• Update lib/winston/create-logger.js and lib/winston/logger.js
• Update test cases in test/unit/winston/logger.test.js

Thank you!! waiting for your response.

[debadutta98]

hi @wbt, is this PR need any improvement

[wbt]

I don't feel like I'm the best person to review this PR, and the PR seems to include a lot of changes not necessarily related to the core of the fix you're trying to contribute (e.g. all the let to const changes, whitespace adjustments, etc.) that tend to bury the more substantive changes (like the addition of .is.not on lines 704 & 775 & 962 of the test).
There also seems to be some unnecessary repetition of new code instead of reusing a new function, which triggers those new complexity warnings, though going through to verify that sections that look repetitive are exactly repetitive and doing that refactoring is a nontrivial effort.
PRs that are large and cover multiple unrelated issues like this, especially unnecessarily so, wind up getting very low priority for the kind of in-depth review that I think is appropriate as a prerequisite for merging into such a widely used project as this. I don't anticipate having the time to do that review on this PR as it stands anytime soon. Maybe somebody else will, or you'll simplify the PR to focus on one specific issue with more DRY code that doesn't trigger new complexity warnings. Thanks for trying!

[bertho-zero]

Why this is closed ?