Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone incoming objects to prevent incoming data mutation (Issue #1775) #2343

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Clone incoming objects to prevent incoming data mutation (Issue #1775) #2343

wants to merge 13 commits into from

Conversation

mattrusso9037
Copy link

This PR solves the issue #1775 by creating a copy of the incoming data before mutating it.

@mattrusso9037
chore(lodash): adding lodash as a dependency to leverage cloneDeep
a903bd0
@mattrusso9037
feat(cloneDeep): added a utility function that creates deep copies of…
89db297 
… an object
@mattrusso9037
feat(logger.js): implement deep copy where data mutation occurs in lo…
be8e67a 
…gger functions
@mattrusso9037
feat(create-logger.js): implement deep copy where data mutation occur…
19ea2c9 
…s in create-logger
@mattrusso9037
fix(logger.js): shallow copy in case where there are 2 parameters
68d6fac
@mattrusso9037
fix(common.js): handle error case by creating a new error since error…
d484d27 
…s cannot be copied
@mattrusso9037
fix(logger.js): handle the case where there is a single parameter
38149d4
@mattrusso9037
refactor(common.js): update error block to use object.assign to ensur…
f708deb 
…e custom properties are not lost. Updated unit test to check properties instead of instance since we are not modifying the original data
@mattrusso9037
refactor(common.js): rm lodash
451061e
@mattrusso9037
Revert "chore(lodash): adding lodash as a dependency to leverage clon…
d297e90 
…eDeep"

This reverts commit a903bd0.
@mattrusso9037
test(errors.test.js): added test to ensure error objects passed in ar…
041b115 
…e not mutated
@mattrusso9037
test(logger.test.js): added test to ensure non-primitive objects pass…
5a36815 
…ed in are not mutated
@mattrusso9037
chore(cfg): rm config
c112410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattrusso9037