Drop unneeded LocalServerObjectCache dependency

Drop BagOStuff $localServerObjectCache . Bug: lakejason0#32 Change-Id: I63a72af01f19eaf75d65dccea8d7134afef9e1d3
winstonsung · Jan 27, 2024 · 3682152 · 3682152
1 parent 0c690f9
commit 3682152
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/RELEASE-NOTES-1.1.md b/RELEASE-NOTES-1.1.md
@@ -38,6 +38,9 @@ risk!
 * Removed unnecessary modules.
 * Fixed CodeMirror glitch.
 * (issue #26) Removed unneeded `wp` prefix from `hide-if`.
+* (issue #32) Fixed "access to private variable `$templateParser` of parent
+  class" in `SkinLakeus.php` by dropping unneeded
+  `BagOStuff $localServerObjectCache` dependency.
 * …
 
 ### Action API changes

diff --git a/includes/SkinLakeus.php b/includes/SkinLakeus.php
@@ -2,24 +2,11 @@
 
 namespace MediaWiki\Skins\Lakeus;
 
-use BagOStuff;
-# use MediaWiki\Html\TemplateParser; // Namespaced in 1.40.0
 # use MediaWiki\SiteStats\SiteStats; // Namespaced in 1.41.0
 use SiteStats;
 use SkinMustache;
-use TemplateParser;
 
 class SkinLakeus extends SkinMustache {
-	/**
-	 * @param BagOStuff $localServerObjectCache
-	 * @param array $options
-	 */
-	public function __construct( BagOStuff $localServerObjectCache, array $options ) {
-		parent::__construct( $options );
-
-		$this->templateParser = new TemplateParser( $this->options['templateDirectory'], $localServerObjectCache );
-	}
-
 	/**
 	 * Extends the getTemplateData function to add a template key 'html-myskin-hello-world'
 	 * which can be rendered in skin.mustache using {{{html-myskin-hello-world}}}

diff --git a/skin.json b/skin.json
@@ -229,9 +229,6 @@
 	"ValidSkinNames": {
 		"lakeus": {
 			"class": "MediaWiki\\Skins\\Lakeus\\SkinLakeus",
-			"services": [
-				"LocalServerObjectCache"
-			],
 			"args": [
 				{
 					"name": "lakeus",