Skip to content

Conversation

@Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 9, 2026


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR hardens iOS call stubs in kalium to prevent runtime crashes in sample/integration flows where calling APIs may be triggered.

What changed:

  • replaced crash-prone TODO stubs in iOS call-related implementations with safe behavior,
  • added explicit kaliumLogger.w(...) warnings for unsupported call operations,
  • kept calling unsupported on iOS (no functional call support added).

Why:

  • avoid Not yet implemented crashes,
  • keep sample app flows stable even if call APIs are touched,
  • make unsupported paths visible via logs for debugging and handoff.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Test Results

0 tests   - 4 331   0 ✅  - 4 214   0s ⏱️ - 5m 50s
0 suites  -   725   0 💤  -   117 
0 files    -   725   0 ❌ ±    0 

Results for commit a4caae8. ± Comparison against base commit 3e70856.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🐰 Bencher Report

Branchchore/ios-calls-noop-logging
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
701.55 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
593,342.67 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,359,626.46 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,175.99 µs
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.57%. Comparing base (ae71a9a) to head (a4caae8).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3854      +/-   ##
===========================================
+ Coverage    59.55%   59.57%   +0.01%     
===========================================
  Files         1898     1900       +2     
  Lines        59197    59466     +269     
  Branches      6417     6456      +39     
===========================================
+ Hits         35255    35424     +169     
- Misses       21027    21073      +46     
- Partials      2915     2969      +54     

see 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae71a9a...a4caae8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


actual override fun observeSpeaker(): Flow<Boolean> {
TODO("Not yet implemented")
return flowOf(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess some warning should still be logged in that case to know that this value is not real 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants