-
Notifications
You must be signed in to change notification settings - Fork 7
chore: replace TODO stubs with Kalium warning logs #3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
| Branch | chore/ios-calls-noop-logging |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 701.55 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 593,342.67 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,359,626.46 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,175.99 µs |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3854 +/- ##
===========================================
+ Coverage 59.55% 59.57% +0.01%
===========================================
Files 1898 1900 +2
Lines 59197 59466 +269
Branches 6417 6456 +39
===========================================
+ Hits 35255 35424 +169
- Misses 21027 21073 +46
- Partials 2915 2969 +54 see 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| actual override fun observeSpeaker(): Flow<Boolean> { | ||
| TODO("Not yet implemented") | ||
| return flowOf(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess some warning should still be logged in that case to know that this value is not real 🤔



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
This PR hardens iOS call stubs in kalium to prevent runtime crashes in sample/integration flows where calling APIs may be triggered.
What changed:
kaliumLogger.w(...)warnings for unsupported call operations,Why: