Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 9, 2026

https://wearezeta.atlassian.net/browse/WPB-21876

https://wearezeta.atlassian.net/browse/WPB-21876

What's new in this PR?

Issues

Wire messenger running with "Keep socket connection" in background looses socket connection to server.

Causes (Optional)

When server closes connection normally (no error) wire app does not try to re-connect.

Solutions

Always try to keep socket connection once it was open. Re-connect even if socket was closed without error.

@sbakhtiarov sbakhtiarov force-pushed the feat/socket-reconnect branch from 04c6d0f to 261242e Compare February 10, 2026 08:18
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Test Results

0 tests   - 4 331   0 ✅  - 4 214   0s ⏱️ - 5m 50s
0 suites  -   725   0 💤  -   117 
0 files    -   725   0 ❌ ±    0 

Results for commit 261242e. ± Comparison against base commit 3e70856.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

🐰 Bencher Report

Branchfeat/socket-reconnect
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
693.07 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
423,948.51 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,366,272.18 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,514.65 µs
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.58%. Comparing base (3e70856) to head (261242e).

Files with missing lines Patch % Lines
...om/wire/kalium/logic/data/event/EventRepository.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3856      +/-   ##
===========================================
+ Coverage    59.57%   59.58%   +0.01%     
===========================================
  Files         1900     1900              
  Lines        59466    59468       +2     
  Branches      6456     6456              
===========================================
+ Hits         35426    35434       +8     
+ Misses       21073    21067       -6     
  Partials      2967     2967              
Files with missing lines Coverage Δ
...om/wire/kalium/logic/data/event/EventRepository.kt 52.00% <66.66%> (+1.49%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e70856...261242e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants