-
Notifications
You must be signed in to change notification settings - Fork 7
feat: reconnect socket when closed normally (WPB-21876) #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
04c6d0f to
261242e
Compare
|
|
| Branch | feat/socket-reconnect |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 693.07 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 423,948.51 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,366,272.18 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,514.65 µs |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3856 +/- ##
===========================================
+ Coverage 59.57% 59.58% +0.01%
===========================================
Files 1900 1900
Lines 59466 59468 +2
Branches 6456 6456
===========================================
+ Hits 35426 35434 +8
+ Misses 21073 21067 -6
Partials 2967 2967
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|



https://wearezeta.atlassian.net/browse/WPB-21876
https://wearezeta.atlassian.net/browse/WPB-21876
What's new in this PR?
Issues
Wire messenger running with "Keep socket connection" in background looses socket connection to server.
Causes (Optional)
When server closes connection normally (no error) wire app does not try to re-connect.
Solutions
Always try to keep socket connection once it was open. Re-connect even if socket was closed without error.