test: sso devce backup critical flow test(WPB-20253) #4317
Conversation
|
|
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
|
@emmaoke-w looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@emmaoke-w looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
|
||
| teamServiceHelper.userXIsMe("user2Name") | ||
|
|
||
| teamOwner = teamHelper?.usersManager!!.findUserBy( |
There was a problem hiding this comment.
teamHelper is non-nullable in this class so ? and !! can be removed
| val serial = runShellCommand("getprop ro.boot.serialno").trim() | ||
|
|
||
| when (serial) { | ||
| "ce091829205f7a3704" -> { | ||
| runShellCommand("pm clear org.lineageos.jelly") | ||
| } | ||
|
|
||
| "25181JEGR05249" -> { | ||
| runShellCommand("pm clear app.vanadium.browser") | ||
| } | ||
|
|
||
| else -> { | ||
| runShellCommand("pm clear com.android.chrome") | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure if that's the best approach, because it means that for this one and only device with this specific serial number "ce091829205f7a3704" it will clear LineageOS Jelly browser cache and for another one and only specific device it will clear Vanadium cache - do we always run these tests only on these devices with Jelly or Vanadium browsers?
Maybe it would be better to always call commands for all three browsers, if there is no such browser on current device then the command will just return "Failed" instead of "Success", but we don't do anything with the result here so it shouldn't break anything. 🤔
| External("External") | ||
| } | ||
|
|
||
| enum class TeamRole(val permissionBitMask: Int) { |
There was a problem hiding this comment.
Can we just merge TeamRoles and TeamRole into one enum class? 🤔
Like:
enum class TeamRoles(val role: String, val permissionBitMask: Int) {
Owner("Owner", 8191),
etc.
)
|
3 participants
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
-Implement test to login via sso, create a backup , log out and log in to restore the backup
-Adapt okta API client
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
sso login device backup
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.