-
Notifications
You must be signed in to change notification settings - Fork 45
fix: e2ei identity certificate status (WPB-20235) #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
6ff56a7 to
ca31217
Compare
ca31217 to
ee6cfc7
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4565 +/- ##
===========================================
- Coverage 48.65% 48.64% -0.01%
===========================================
Files 576 576
Lines 19942 19950 +8
Branches 3335 3336 +1
===========================================
+ Hits 9702 9705 +3
- Misses 9214 9218 +4
- Partials 1026 1027 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|



https://wearezeta.atlassian.net/browse/WPB-20235
What's new in this PR?
Issue
When User A views User B's device details (both from the same team with E2EI enabled), the UI shows:
This happens even when User B has a valid E2EI certificate.
Cause
Users A and B only have Proteus conversations, no MLS conversations. E2EI identity lookup via CoreCrypto requires an MLS group ID, so when there's no common MLS conversation, the lookup fails with
StorageFailure.DataNotFound.Previously, all failures from
GetMLSClientIdentityUseCasewere treated the same, resulting inmlsClientIdentity = null. The UI then displayed this as "Not activated" with an error icon, which is incorrect - the E2EI data is simply unavailable, not "not activated".Solution
Handle the
E2EINotAvailablefailure case separately and hide E2EI-related UI elements when E2EI identity data cannot be retrieved due to lack of common MLS conversation.