Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate supported protocols - WPB-15297 #2384

Merged
merged 11 commits into from
Jan 14, 2025

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Jan 13, 2025

BugWPB-15297 [iOS] Wrong Supported protocols

Issue

During the calculation of the supported protocols, we look if all the self clients support MLS. The calculation depends on the MLS public key and the lastActive date fields of the client. Those two fields don't come from the userClientAdd event. Moreover, the upload of the MLS public keys is not done on login but a bit later for each client.

For all that reasons, we need to fetch the self clients to retrieve this information. This PR fetches the self clients before doing calculation of supported protocols.

  • remove fix before MLS was enabled (calculateSupportedProtocolsIfNeeded)
  • extracted code from UserClientsRepository to own object PullSelfUserClients
  • add closure to build PullSelfUserClients to ResolveOneOnOneConversationsUseCase

Testing

See steps in ticket


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 13, 2025
@netbe netbe force-pushed the fix/WPB-15297-supported-protocols branch from ced5dfb to 18b3907 Compare January 13, 2025 16:30
@netbe netbe marked this pull request as ready for review January 13, 2025 16:40
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

1 739 tests   1 737 ✅  2m 13s ⏱️
    3 suites      2 💤
    3 files        0 ❌

Results for commit a71722f.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 13, 2025

Datadog Report

Branch report: fix/WPB-15297-supported-protocols
Commit report: a5d3802
Test service: wire-ios-mono

✅ 0 Failed, 1703 Passed, 2 Skipped, 2m 7.73s Total Time

@netbe netbe requested review from a team, El-Fitz, johnxnguyen and jullianm and removed request for a team January 13, 2025 20:06
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netbe netbe enabled auto-merge January 14, 2025 11:11
@netbe netbe added this pull request to the merge queue Jan 14, 2025
Merged via the queue into develop with commit 480e9f2 Jan 14, 2025
13 checks passed
@netbe netbe deleted the fix/WPB-15297-supported-protocols branch January 14, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants