-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calculate supported protocols - WPB-15297 #2384
Conversation
ced5dfb
to
18b3907
Compare
Test Results1 739 tests 1 737 ✅ 2m 13s ⏱️ Results for commit a71722f. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1703 Passed, 2 Skipped, 2m 7.73s Total Time |
wire-ios-sync-engine/Source/Use cases/ResolveOneOnOneConversationsUseCase.swift
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/UseCases/PullSelfUserClients.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
During the calculation of the supported protocols, we look if all the self clients support MLS. The calculation depends on the MLS public key and the lastActive date fields of the client. Those two fields don't come from the
userClientAdd
event. Moreover, the upload of the MLS public keys is not done on login but a bit later for each client.For all that reasons, we need to fetch the self clients to retrieve this information. This PR fetches the self clients before doing calculation of supported protocols.
PullSelfUserClients
Testing
See steps in ticket
Checklist
[WPB-XXX]
.