Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move use case into WireDomainPkg - WPB-10347 #2393

Merged
merged 16 commits into from
Jan 20, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 16, 2025

EpicWPB-10347 B - Individuals creating a New Team

Issue

This PR deletes unused Swift package targets and moves the IndividualToTeamMigrationUseCaseProtocol into WireDomainPkg.

Screenshot 2025-01-16 at 17 31 10

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian force-pushed the chore/remove-wiredomainapi-WPB-10347 branch from 3b20e3e to 658102c Compare January 16, 2025 15:31
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test Results

    4 files     13 suites   4m 35s ⏱️
3 392 tests 3 363 ✅ 29 💤 0 ❌
3 403 runs  3 374 ✅ 29 💤 0 ❌

Results for commit 77bbccb.

♻️ This comment has been updated with latest results.

@caldrian caldrian changed the base branch from develop to refactor/close-button-WPB-15211 January 16, 2025 15:48
@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 16, 2025

Datadog Report

Branch report: chore/remove-wiredomainapi-WPB-10347
Commit report: 75f6d4b
Test service: wire-ios-mono

✅ 0 Failed, 3247 Passed, 29 Skipped, 2m 23.5s Total Time

Base automatically changed from refactor/close-button-WPB-15211 to develop January 16, 2025 16:21
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why do we have unused targets in the first place?

@caldrian
Copy link
Contributor Author

caldrian commented Jan 17, 2025

why do we have unused targets in the first place?

@netbe I had expected the WireDomain project to be a short-term temporary solution.

@caldrian caldrian enabled auto-merge January 17, 2025 11:28
@caldrian caldrian requested a review from El-Fitz January 17, 2025 11:28
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a couple of (non-blocking) comments 👍

@caldrian caldrian added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit ae07a99 Jan 20, 2025
13 of 14 checks passed
@caldrian caldrian deleted the chore/remove-wiredomainapi-WPB-10347 branch January 20, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants