-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move use case into WireDomainPkg - WPB-10347 #2393
Conversation
3b20e3e
to
658102c
Compare
Test Results 4 files 13 suites 4m 35s ⏱️ Results for commit 77bbccb. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 3247 Passed, 29 Skipped, 2m 23.5s Total Time |
…lose-button-WPB-15211
…domainapi-WPB-10347
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why do we have unused targets in the first place?
@netbe I had expected the WireDomain project to be a short-term temporary solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left a couple of (non-blocking) comments 👍
Issue
This PR deletes unused Swift package targets and moves the
IndividualToTeamMigrationUseCaseProtocol
intoWireDomainPkg
.Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: