refactor: generate notification incoming/missed call - WPB-11664 #2397
+1,489
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points
This PR is about generating notification content related to calling events (incoming call, missed call) which can be either handled by the
CallKitNotificationBuilder
which will show the built-in CallKit notification or by theCallNotificationBuilder
in case we only need to show a regular push notification.Logic to decide which builder to use is done through the
shouldBuildNotification()
method in order to be consistent with the new NSE structure.Testing
CallKit
notification is correctly generated.Checklist
[WPB-XXX]
.