-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create conversation import use case - WPB-14599 #2402
Merged
caldrian
merged 138 commits into
develop
from
feat/create-conversation-import-use-case-WPB-14599
Jan 28, 2025
Merged
feat: create conversation import use case - WPB-14599 #2402
caldrian
merged 138 commits into
develop
from
feat/create-conversation-import-use-case-WPB-14599
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-conversation-import-use-case-WPB-14596
…-WPB-14596' into feat/create-conversation-import-use-case-WPB-14596
…rate-protocols-from-implementation-wiredomain-WPB-14596 # Conflicts: # WireDomain/Sources/WireDomain/Synchronization/PullSelfLegalholdInfoSync.swift
…-WPB-14596' into feat/create-conversation-import-use-case-WPB-14596
…rate-protocols-from-implementation-wiredomain-WPB-14596
…-WPB-14596' into feat/create-conversation-import-use-case-WPB-14596
…e-conversation-import-use-case-WPB-14596
Test Results3 749 tests 3 747 ✅ 6m 52s ⏱️ Results for commit fc95584. ♻️ This comment has been updated with latest results. |
…n-up-legacy-code-WPB-14599.wip
…conversation-import-use-case-WPB-14599
…conversation-import-use-case-WPB-14599
…n-up-legacy-code-WPB-14599
…conversation-import-use-case-WPB-14599.wip
johnxnguyen
approved these changes
Jan 28, 2025
wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportBackupUseCase.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Tests/Source/Use cases/ImportBackupUseCaseTests.swift
Show resolved
Hide resolved
…e-conversation-import-use-case-WPB-14599
…e-conversation-import-use-case-WPB-14599
netbe
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment to remove the workqueue, the rest looks good
wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportBackupUseCase.swift
Outdated
Show resolved
Hide resolved
caldrian
deleted the
feat/create-conversation-import-use-case-WPB-14599
branch
January 28, 2025 13:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR creates a use case which allows for restoring a backup from an active session.
Testing
No UI attached, so not testable yet.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: