Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mls system message - WPB-15129 #2411

Merged
merged 16 commits into from
Jan 29, 2025
Merged

fix: mls system message - WPB-15129 #2411

merged 16 commits into from
Jan 29, 2025

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Jan 22, 2025 •
edited
Loading

BugWPB-15129 [iOS] no system message when MLS becomes the protocol for the conversation

Issue

When migrating one on one proteus conversation to mls, the system message is missing. This PR adds the system message.

  • Also ports the logic to new code on OneOnOneResolver

Testing

  • create proteus team
  • have 1-1 conv
  • migrate to MLS
  • check 1-1 conv contains MLS system message

IMG_0129

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 22, 2025
@netbe netbe force-pushed the fix/mls-message-WPB-15129 branch from dd9434e to 215dcab Compare January 27, 2025 09:38
@netbe netbe force-pushed the fix/mls-message-WPB-15129 branch from ae87a38 to a74048a Compare January 27, 2025 15:08
@netbe netbe changed the base branch from develop to release/cycle-3.116 January 27, 2025 15:08
@netbe netbe marked this pull request as ready for review January 27, 2025 15:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Test Results

2 639 tests   2 639 ✅  5m 8s ⏱️
    2 suites      0 💤
    2 files        0 ❌

Results for commit 01ce733.

♻️ This comment has been updated with latest results.

@netbe netbe requested a review from KaterinaWire January 28, 2025 19:16
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/mls-message-WPB-15129
Commit report: 8789aa9
Test service: wire-ios-mono

✅ 0 Failed, 2553 Passed, 0 Skipped, 5m 3.17s Total Time

@netbe netbe merged commit 7fe488e into release/cycle-3.116 Jan 29, 2025
10 of 11 checks passed
@netbe netbe deleted the fix/mls-message-WPB-15129 branch January 29, 2025 10:16
zenkins pushed a commit that referenced this pull request Jan 29, 2025
@netbe @github-actions
fix: mls system message - WPB-15129 (#2411)
3743f12
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaterinaWire KaterinaWire KaterinaWire approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@jullianm jullianm Awaiting requested review from jullianm

Assignees

@netbe netbe

Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netbe @johnxnguyen @KaterinaWire