Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Setup Wire Edge app - WPB-15280 #2420

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: Setup Wire Edge app - WPB-15280 #2420

wants to merge 9 commits into from
+8 −3

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Jan 24, 2025 •
edited
Loading

StoryWPB-15280 Create Wire Edge app

Issue

  1. Development workflow renamed to Edge.
  2. Updated development fastlane lane.

Todo:

  1. Add EDGE_TESTFLIGHT_LINK to secrets.
  2. Update the "wire-ios-build-assets" link with Edge configurations.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Jan 24, 2025
@KaterinaWire KaterinaWire requested a review from netbe January 24, 2025 10:06
@KaterinaWire KaterinaWire marked this pull request as ready for review January 24, 2025 10:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d045fe7.

♻️ This comment has been updated with latest results.

netbe
netbe approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have to wait for apple APPLE_EXPORT_COMPLIANCE_CODE

samwyndham
samwyndham approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to edge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@netbe netbe netbe approved these changes

Assignees

@KaterinaWire KaterinaWire

Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaterinaWire @netbe @samwyndham