chore: Migrate some obj-c code to Swift in WireImages - WPB-15697
#2426
+304
−572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gesWithATIFFOrientation()`
…gesWithTIFFOrientation5()`
…gesWithTIFFOrientation7()`
Rely on imported version WireTesting implementation instead
samwyndham
requested review from
a team,
netbe,
El-Fitz,
johnxnguyen and
caldrian
and removed request for
a team,
El-Fitz and
johnxnguyen
Test Results62 tests 62 ✅ 12s ⏱️ Results for commit 4c5b478. |
Datadog ReportBranch report: ✅ 0 Failed, 62 Passed, 0 Skipped, 12.06s Total Time |
caldrian
approved these changes
Jan 29, 2025
Comment on lines
+22
to
+24
| @objc | ||
| public class ZMIImageProperties: NSObject { | ||
| @objc public let size: CGSize |
There was a problem hiding this comment.
Suggested change
| @objc | |
| public class ZMIImageProperties: NSObject { | |
| @objc public let size: CGSize | |
| @objc @objcMembers | |
| public class ZMIImageProperties: NSObject { | |
| public let size: CGSize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is made as part of platform day and includes migrating some
obj-ccode toSwiftin theWireImagesproject. It also includes making theTestsgroup into a folder.Unfortunately I only touched the surface and there is still a bunch more
obj-cto migrate away.Note to reviewers
Please go commit by commit to make your job easier!
Testing
Run unit tests
Checklist
[WPB-XXX].